MD Settings: Add display layout

MD Settings: Add display layout

This correctly sizes and positions displays, but does not support
dragging yet.

BUG=547080
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

For trivial change to display_info_provider_chromeos.cc:
TBR=asargent@chromium.org

Committed: https://crrev.com/587e5f5dd32f3ce79ff084e60ff6c0eaebbfec3c
Cr-Commit-Position: refs/heads/master@{#401989}

[stevenjb, 2016-06-20 21:26:18]

Description was changed from

==========
MD Settings: Add display layout

This correctly sizes and positions displays, but does not support
dragging yet.

BUG=547080
==========

to

==========
MD Settings: Add display layout

This correctly sizes and positions displays, but does not support
dragging yet.

BUG=547080
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-06-20 23:32:29]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[stevenjb, 2016-06-21 19:12:34]

Description was changed from

==========
MD Settings: Add display layout

This correctly sizes and positions displays, but does not support
dragging yet.

BUG=547080
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Add display layout

This correctly sizes and positions displays, but does not support
dragging yet.

BUG=547080
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

For trivial change to display_info_provider_chromeos.cc:
TBR=asargent@chromium.org
==========

[stevenjb, 2016-06-21 19:12:53]

The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 19:13:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084673003/60001

[commit-bot: I haz the power, 2016-06-21 19:21:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 19:21:53]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[michaelpg, 2016-06-22 21:57:58]

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.html (right):

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.html:3: <!-- DO NOT
SUBMIT: Fix Page Title. Missing tags? http://go/optional-html -->
?

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.js (right):

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:2: *
@fileoverview Description of this file.
remove

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:10: *
'display-layout' presents a visual representaiton of the layout of one or
representation

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:13: * @group
Chrome Settings Elements
remove

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:52: /** @type
{!Object<chrome.system.display.DisplayUnitInfo>} */
s/type/private here & below

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:84: for (var
layout of this.layouts)
let, for consistency?

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:99:
calculateDisplayArea_() {
to clarify: is the "display area" something to do with a monitor, or the space
on the page that's available to your element?

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:106: var
boundingBox = {left: 0, right: 0, top: 0, bottom: 0};
The bounding box of what?

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:110:
boundingBox.left = Math.min(boundingBox.left, bounds.left);
this ensures boundingBox.left is always 0 or less, is that the intention? i.e.,
can bounds.left be negative?

[stevenjb, 2016-06-22 23:38:53]

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.html (right):

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.html:3: <!-- DO NOT
SUBMIT: Fix Page Title. Missing tags? http://go/optional-html -->
On 2016/06/22 21:57:57, michaelpg wrote:
> ?

Sigh. Stupid editor. One of these days I will figure out how this happens.
Removed.

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.js (right):

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:2: *
@fileoverview Description of this file.
On 2016/06/22 21:57:57, michaelpg wrote:
> remove

Done.

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:10: *
'display-layout' presents a visual representaiton of the layout of one or
On 2016/06/22 21:57:58, michaelpg wrote:
> representation

Done.

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:13: * @group
Chrome Settings Elements
On 2016/06/22 21:57:57, michaelpg wrote:
> remove

Done.

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:52: /** @type
{!Object<chrome.system.display.DisplayUnitInfo>} */
On 2016/06/22 21:57:57, michaelpg wrote:
> s/type/private here & below

Done.

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:84: for (var
layout of this.layouts)
On 2016/06/22 21:57:57, michaelpg wrote:
> let, for consistency?

Done.

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:99:
calculateDisplayArea_() {
On 2016/06/22 21:57:58, michaelpg wrote:
> to clarify: is the "display area" something to do with a monitor, or the space
> on the page that's available to your element?

Renamed calculateVisualScale and tried to improve the comment for the property
and the function. 'visualScale' isn't great, but kind of infers the intent and
any name is going to be confusing.

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:106: var
boundingBox = {left: 0, right: 0, top: 0, bottom: 0};
On 2016/06/22 21:57:58, michaelpg wrote:
> The bounding box of what?

Renamed displayInfoBoundingBox (a box bounding all of the display info bounds)

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:110:
boundingBox.left = Math.min(boundingBox.left, bounds.left);
On 2016/06/22 21:57:58, michaelpg wrote:
> this ensures boundingBox.left is always 0 or less, is that the intention?
i.e.,
> can bounds.left be negative?

Good catch. In practice the primary display bounding box generally starts at 0,0
which is why I didn't notice this, but we really shouldn't assume that. Fixed.

[stevenjb, 2016-06-23 01:51:33]

I also had to make some non trivial changes to fix the tests which I (clearly)
forgot to run.

PTAL

[michaelpg, 2016-06-23 04:29:35]

I started commenting on the previous patch first, so ignore any comments that
are out of date.

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.html (right):

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.html:3: <!-- DO NOT
SUBMIT: Fix Page Title. Missing tags? http://go/optional-html -->
On 2016/06/22 23:38:52, stevenjb wrote:
> On 2016/06/22 21:57:57, michaelpg wrote:
> > ?
> 
> Sigh. Stupid editor. One of these days I will figure out how this happens.
> Removed.

Maybe Google's emacs config triggers this?

https://goto.google.com/yecgl

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.html (right):

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.html:9: /* Use
relative position with no offset so that the diplay divs (children),
all indent inside <style> is off by one

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.html:9: /* Use
relative position with no offset so that the diplay divs (children),
display

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.html:31: <div
id="displayArea" on-iron-resize="calculateDisplayArea_">
calculateVisualScale_? (this should show a console warning btw)

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.js (right):

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:104: {left:
Number.MAX_VALUE, right: 0, top: Number.MAX_VALUE, bottom: 0};
Normally the origin (0, 0) is the top-left, and the bottom is greater than the
top.

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:121: // largest
display.
display(s) -- e.g., a landscape display and a portrait display could give you
maxWidth and maxHeight from different displays

(so the code is right, but the comment isn't quite)

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:151: /** @const
{number} */ var BORDER = 2;
why 2, when the border with on .display is 1?

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:153: var height
= Math.round(bounds.height * this.visualScale) - BORDER * 2;
I think using box-sizing: border-box on these divs can remove the need to
account for the border manually.

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:156:
this.visualOffset_.left + Math.round(bounds.left * this.visualScale);
why round the 2nd term but not the offset?

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:159: var style =
'height:' + height + 'px;' + 'width:' + width + 'px;' +
i think this is a great use case for es6 template strings if closure will allow
it:

return `height: ${height}px; width: ${width}px; ...`;

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:175: * @param
{!{model: !{index: number}, target: !PaperButtonElement}} e
meh, remove unused target property info

https://codereview.chromium.org/2084673003/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/settings/device_page/display_layout.js (right):

https://codereview.chromium.org/2084673003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/device_page/display_layout.js:204: var
parentDisplay = this.displayMap_[layout.parentId];
layout.parentId can be '', making parentDisplay undefined, making line 206
throw. Unless (layout.parentId == '') always implies (display.isPrimary) but it
doesn't sound like the primary display always has to be the root.

If I'm right, add a test case :-)

https://codereview.chromium.org/2084673003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/device_page/display_layout.js:206: if
(parentDisplay.id in this.boundsMap_)
it's a little weird that calcDisplayBounds_ both returns and caches. Maybe don't
return the result, and do:

if (!(parentDisplay.id in this.boundsMap_))
  this.calcDisplayBounds_(parentDisplay);
var parentBounds = this.boundsmap_[parentDisplay.id];

which IMO is simpler all around.

https://codereview.chromium.org/2084673003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/device_page/display_layout.js:209:
parentBounds = this.calcDisplayBounds_(parentDisplay);
Does this mean calcDisplayBounds_ could be called twice for a parent -- once
here, then later, once in the remainder of the updateDisplays loop? I think yes,
unless the display list is ordered like a tree (but then this else condition
would never occur)

[stevenjb, 2016-06-23 19:11:02]

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.html (right):

https://codereview.chromium.org/2084673003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.html:3: <!-- DO NOT
SUBMIT: Fix Page Title. Missing tags? http://go/optional-html -->
On 2016/06/23 04:29:34, michaelpg wrote:
> On 2016/06/22 23:38:52, stevenjb wrote:
> > On 2016/06/22 21:57:57, michaelpg wrote:
> > > ?
> > 
> > Sigh. Stupid editor. One of these days I will figure out how this happens.
> > Removed.
> 
> Maybe Google's emacs config triggers this?
> 
> https://goto.google.com/yecgl

Good theory but I can't find anywhere in emacs that directly triggers 'genhtml'.
Sigh.

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.html (right):

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.html:9: /* Use
relative position with no offset so that the diplay divs (children),
On 2016/06/23 04:29:34, michaelpg wrote:
> all indent inside <style> is off by one

Done.

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.html:9: /* Use
relative position with no offset so that the diplay divs (children),
On 2016/06/23 04:29:34, michaelpg wrote:
> display

Done.

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.html:31: <div
id="displayArea" on-iron-resize="calculateDisplayArea_">
On 2016/06/23 04:29:34, michaelpg wrote:
> calculateVisualScale_? (this should show a console warning btw)

Doh. Didn't test resize.

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.js (right):

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:104: {left:
Number.MAX_VALUE, right: 0, top: Number.MAX_VALUE, bottom: 0};
On 2016/06/23 04:29:35, michaelpg wrote:
> Normally the origin (0, 0) is the top-left, and the bottom is greater than the
> top.

The intention is that these will be immediately overwritten. I will initialize
this to the first display instead to make this more clear.

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:121: // largest
display.
On 2016/06/23 04:29:34, michaelpg wrote:
> display(s) -- e.g., a landscape display and a portrait display could give you
> maxWidth and maxHeight from different displays
> 
> (so the code is right, but the comment isn't quite)

Done.

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:151: /** @const
{number} */ var BORDER = 2;
On 2016/06/23 04:29:35, michaelpg wrote:
> why 2, when the border with on .display is 1?

It has a box shadow of width 2. Added a comment.

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:153: var height
= Math.round(bounds.height * this.visualScale) - BORDER * 2;
On 2016/06/23 04:29:35, michaelpg wrote:
> I think using box-sizing: border-box on these divs can remove the need to
> account for the border manually.

Alas, your newfangled CSS property doesn't appear to play nicely with
box-shadow. Good thought though.

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:156:
this.visualOffset_.left + Math.round(bounds.left * this.visualScale);
On 2016/06/23 04:29:34, michaelpg wrote:
> why round the 2nd term but not the offset?

Good catch. Fixed.

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:159: var style =
'height:' + height + 'px;' + 'width:' + width + 'px;' +
On 2016/06/23 04:29:35, michaelpg wrote:
> i think this is a great use case for es6 template strings if closure will
allow
> it:
> 
> return `height: ${height}px; width: ${width}px; ...`;

Cute. Closure is fine with it. Done.

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:175: * @param
{!{model: !{index: number}, target: !PaperButtonElement}} e
On 2016/06/23 04:29:35, michaelpg wrote:
> meh, remove unused target property info

Done.

https://codereview.chromium.org/2084673003/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/settings/device_page/display_layout.js (right):

https://codereview.chromium.org/2084673003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/device_page/display_layout.js:204: var
parentDisplay = this.displayMap_[layout.parentId];
On 2016/06/23 04:29:35, michaelpg wrote:
> layout.parentId can be '', making parentDisplay undefined, making line 206
> throw. Unless (layout.parentId == '') always implies (display.isPrimary) but
it
> doesn't sound like the primary display always has to be the root.
> 
> If I'm right, add a test case :-)

The primary display does have to be the root, and there is a test case :) (I had
to fix the fake model to avoid just that problem).

I'll add an assert to document that.

https://codereview.chromium.org/2084673003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/device_page/display_layout.js:206: if
(parentDisplay.id in this.boundsMap_)
On 2016/06/23 04:29:35, michaelpg wrote:
> it's a little weird that calcDisplayBounds_ both returns and caches. Maybe
don't
> return the result, and do:
> 
> if (!(parentDisplay.id in this.boundsMap_))
>   this.calcDisplayBounds_(parentDisplay);
> var parentBounds = this.boundsmap_[parentDisplay.id];
> 
> which IMO is simpler all around.

Meh. Done.

https://codereview.chromium.org/2084673003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/device_page/display_layout.js:209:
parentBounds = this.calcDisplayBounds_(parentDisplay);
On 2016/06/23 04:29:35, michaelpg wrote:
> Does this mean calcDisplayBounds_ could be called twice for a parent -- once
> here, then later, once in the remainder of the updateDisplays loop? I think
yes,
> unless the display list is ordered like a tree (but then this else condition
> would never occur)

Err, yes. I swear I checked the cache at the top of this function at one point,
must have gotten lost. Added.

[michaelpg, 2016-06-24 20:25:11]

lgtm, but I do recommend using reduce()

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.js (right):

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:104: {left:
Number.MAX_VALUE, right: 0, top: Number.MAX_VALUE, bottom: 0};
On 2016/06/23 19:11:01, stevenjb wrote:
> On 2016/06/23 04:29:35, michaelpg wrote:
> > Normally the origin (0, 0) is the top-left, and the bottom is greater than
the
> > top.
> 
> The intention is that these will be immediately overwritten. I will initialize
> this to the first display instead to make this more clear.

If you use Array.prototype.reduce you wouldn't have to explicitly initialize
these (that's how blink unions all the rects in GetBoundingClientRect, btw)

https://codereview.chromium.org/2084673003/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/settings/device_page/display_layout.html (right):

https://codereview.chromium.org/2084673003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/settings/device_page/display_layout.html:9: /* Use
relative position with no offset so that display divs(children),
nit: space before (children)

[stevenjb, 2016-06-24 20:59:51]

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/device_page/display_layout.js (right):

https://codereview.chromium.org/2084673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/device_page/display_layout.js:104: {left:
Number.MAX_VALUE, right: 0, top: Number.MAX_VALUE, bottom: 0};
On 2016/06/24 20:25:10, michaelpg wrote:
> On 2016/06/23 19:11:01, stevenjb wrote:
> > On 2016/06/23 04:29:35, michaelpg wrote:
> > > Normally the origin (0, 0) is the top-left, and the bottom is greater than
> the
> > > top.
> > 
> > The intention is that these will be immediately overwritten. I will
initialize
> > this to the first display instead to make this more clear.
> 
> If you use Array.prototype.reduce you wouldn't have to explicitly initialize
> these (that's how blink unions all the rects in GetBoundingClientRect, btw)

Interesting. I can see how that would be useful, but here I am also:
* converting left/right/width/height to left/right/top/bottom
* calculating the max width and height of any individual bounds

I could do it in a couple of reduce() functions but they would be not trivial
and I think ultimately a bit harder to read than what I ended up with.

https://codereview.chromium.org/2084673003/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/settings/device_page/display_layout.html (right):

https://codereview.chromium.org/2084673003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/settings/device_page/display_layout.html:9: /* Use
relative position with no offset so that display divs(children),
On 2016/06/24 20:25:10, michaelpg wrote:
> nit: space before (children)

Done.

[stevenjb, 2016-06-24 20:59:58]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-06-24 20:59:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2084673003/#ps140001
(title: "Nit")

[commit-bot: I haz the power, 2016-06-24 21:00:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 22:00:24]

Description was changed from

==========
MD Settings: Add display layout

This correctly sizes and positions displays, but does not support
dragging yet.

BUG=547080
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

For trivial change to display_info_provider_chromeos.cc:
TBR=asargent@chromium.org
==========

to

==========
MD Settings: Add display layout

This correctly sizes and positions displays, but does not support
dragging yet.

BUG=547080
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

For trivial change to display_info_provider_chromeos.cc:
TBR=asargent@chromium.org
==========

[commit-bot: I haz the power, 2016-06-24 22:00:27]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-06-24 22:03:46]

Description was changed from

==========
MD Settings: Add display layout

This correctly sizes and positions displays, but does not support
dragging yet.

BUG=547080
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

For trivial change to display_info_provider_chromeos.cc:
TBR=asargent@chromium.org
==========

to

==========
MD Settings: Add display layout

This correctly sizes and positions displays, but does not support
dragging yet.

BUG=547080
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

For trivial change to display_info_provider_chromeos.cc:
TBR=asargent@chromium.org

Committed: https://crrev.com/587e5f5dd32f3ce79ff084e60ff6c0eaebbfec3c
Cr-Commit-Position: refs/heads/master@{#401989}
==========

[commit-bot: I haz the power, 2016-06-24 22:03:48]

Patchset 8 (id:??) landed as
https://crrev.com/587e5f5dd32f3ce79ff084e60ff6c0eaebbfec3c
Cr-Commit-Position: refs/heads/master@{#401989}