Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2097793004: MD Settings: Display: Implement dragging (Closed)

Created:
4 years, 5 months ago by stevenjb
Modified:
4 years, 5 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dcheng, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_547080_display_settings7
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Display: Implement dragging This introduces drag behavior, but does not persist new positions. BUG=547080 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/578e7842301164aa41e4f5ba08cd9fd078626f88 Cr-Commit-Position: refs/heads/master@{#402354}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 10

Patch Set 4 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -34 lines) Patch
M chrome/browser/resources/settings/device_page/compiled_resources2.gyp View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/device_page/display_layout.html View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/device_page/display_layout.js View 1 10 chunks +86 lines, -31 lines 0 comments Download
A chrome/browser/resources/settings/device_page/drag_behavior.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/settings/device_page/drag_behavior.js View 1 2 3 1 chunk +220 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
stevenjb
Display layout 1/3
4 years, 5 months ago (2016-06-24 20:27:18 UTC) #3
michaelpg
https://codereview.chromium.org/2097793004/diff/40001/chrome/browser/resources/settings/device_page/drag_behavior.js File chrome/browser/resources/settings/device_page/drag_behavior.js (right): https://codereview.chromium.org/2097793004/diff/40001/chrome/browser/resources/settings/device_page/drag_behavior.js#newcode35 chrome/browser/resources/settings/device_page/drag_behavior.js:35: /** @private {?DragPosition} */ is it really nullable? (if ...
4 years, 5 months ago (2016-06-24 21:00:11 UTC) #4
stevenjb
PTAL, Thanks! https://codereview.chromium.org/2097793004/diff/40001/chrome/browser/resources/settings/device_page/drag_behavior.js File chrome/browser/resources/settings/device_page/drag_behavior.js (right): https://codereview.chromium.org/2097793004/diff/40001/chrome/browser/resources/settings/device_page/drag_behavior.js#newcode35 chrome/browser/resources/settings/device_page/drag_behavior.js:35: /** @private {?DragPosition} */ On 2016/06/24 21:00:10, ...
4 years, 5 months ago (2016-06-24 21:44:12 UTC) #5
michaelpg
lgtm
4 years, 5 months ago (2016-06-27 21:32:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097793004/60001
4 years, 5 months ago (2016-06-27 22:03:06 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-28 01:04:27 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 01:05:56 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/578e7842301164aa41e4f5ba08cd9fd078626f88
Cr-Commit-Position: refs/heads/master@{#402354}

Powered by Google App Engine
This is Rietveld 408576698