chrome/browser/resources/settings/device_page/display_layout.html - Issue 2084673003: MD Settings: Add display layout

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/device_page/display_layout.html

Issue 2084673003: MD Settings: Add display layout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_547080_display_settings6

Patch Set: Feedback Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/device_page/display.js ('k') | chrome/browser/resources/settings/device_page/display_layout.js » ('j') | chrome/browser/resources/settings/device_page/display_layout.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-resizable-behavior /iron-resizable-behavior.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

	4 <link rel="import" href="/settings_shared_css.html">

	5

	6 <dom-module id="display-layout">

	7 <template>

	8 <style include="settings-shared">

	9 /* Use relative position with no offset so that the diplay divs (children),
	michaelpg 2016/06/23 04:29:34 all indent inside <style> is off by one all indent inside <style> is off by one michaelpg 2016/06/23 04:29:34 display display stevenjb 2016/06/23 19:11:01 Done. Show quoted text On 2016/06/23 04:29:34, michaelpg wrote: > all indent inside <style> is off by one Done. stevenjb 2016/06/23 19:11:01 Done. Show quoted text On 2016/06/23 04:29:34, michaelpg wrote: > display Done.
	10 which have absolute positions, are offset from the displayArea div. */

	11 #displayArea {

	12 border: lightgrey solid 1px;

	13 height: 100%;

	14 position: relative;

	15 width: 100%;

	16 }

	17 .display {

	18 align-items: center;

	19 background: var(--paper-grey-200);

	20 border: var(--paper-grey-200) solid 1px;

	21 box-shadow: 2px 2px var(--paper-grey-400);

	22 display: flex;

	23 justify-content: center;

	24 position: absolute;

	25 }

	26 .display[selected] {

	27 border: var(--google-blue-500) solid 2px;

	28 box-shadow: none;

	29 }

	30 </style>

	31 <div id="displayArea" on-iron-resize="calculateDisplayArea_">
	michaelpg 2016/06/23 04:29:34 calculateVisualScale_? (this should show a console calculateVisualScale_? (this should show a console warning btw) stevenjb 2016/06/23 19:11:01 Doh. Didn't test resize. Show quoted text On 2016/06/23 04:29:34, michaelpg wrote: > calculateVisualScale_? (this should show a console warning btw) Doh. Didn't test resize.
	32 <template is="dom-repeat" items="[[displays]]">

	33 <div class="display" style$="[[getDivStyle_(item, visualScale)]]"

	34 selected$="[[isSelected_(item, selectedDisplay)]]"

	35 on-tap="onSelectDisplayTap_">

	36 [[item.name]]

	37 </div>

	38 </template>

	39 </div>

	40 </template>

	41 <script src="display_layout.js"></script>

	42 </dom-module>

OLD	NEW