Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2084243003: Potential fix for flaky TSAN (Closed)

Created:
4 years, 6 months ago by msarett
Modified:
4 years, 6 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/ColorSpaceXformTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
msarett
TSAN is occasionally complaining about this test. I think this'll fix it. I also think ...
4 years, 6 months ago (2016-06-22 21:56:25 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084243003/1
4 years, 6 months ago (2016-06-22 21:56:37 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 22:20:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084243003/1
4 years, 6 months ago (2016-06-22 22:28:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/949999d0bbc247906995358a90c4e436e9152de2
4 years, 6 months ago (2016-06-22 22:29:06 UTC) #12
mtklein
Yup, yup, SkMatrix4::I() is clearly not thread safe in a world of -fno-thread-safe-statics. lgtm. Don't ...
4 years, 6 months ago (2016-06-23 00:51:00 UTC) #13
msarett
4 years, 6 months ago (2016-06-23 19:48:29 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2091573004/ by msarett@google.com.

The reason for reverting is: I believe I've fixed SkMatrix44::I() to be thread
safe, let's test it by reverting this CL..

Powered by Google App Engine
This is Rietveld 408576698