tests/ColorSpaceXformTest.cpp - Issue 2084243003: Potential fix for flaky TSAN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/ColorSpaceXformTest.cpp

Issue 2084243003: Potential fix for flaky TSAN (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/ColorSpaceXformTest.cpp

diff --git a/tests/ColorSpaceXformTest.cpp b/tests/ColorSpaceXformTest.cpp

index 9d0315b24944aac24e0210b92d7d347438930997..c528bf65bc060a28ba6ae50c7d9eed51ba15a734 100644

--- a/tests/ColorSpaceXformTest.cpp

+++ b/tests/ColorSpaceXformTest.cpp

@@ -30,7 +30,7 @@ static void test_xform(skiatest::Reporter* r, const sk_sp<SkGammas>& gammas) {

uint32_t dstPixels[width];

// Identity matrix

- SkMatrix44 srcToDst = SkMatrix44::I();

+ SkMatrix44 srcToDst(SkMatrix44::kIdentity_Constructor);

// Create and perform xform

std::unique_ptr<SkColorSpaceXform> xform(

« no previous file with comments | « no previous file | no next file » | no next file with comments »