Adding an interface to allow extension of the audio player for CRD and iOS.

Adding an interface to allow extension of the audio player for CRD and iOS.

This CL changes the audio player for CRD into a consumer of audio packets. The choice of consumer is based on a consumer/provider pattern, the intent is to create a new class that will be used in iOS in a following CL that acts as a middle buffer between the CRD Client and the iOS audio player which will extend both AudioConsumer and AudioProvider(not in this CL). Because of this change, I needed the current usage of audio player to extend from a more generic interface (AudioConsumer) which could apply to either this future buffer or audio player.

This is a followup to https://codereview.chromium.org/2052723002, I missed the last upload for the CL changes.

R=sergeyu@chromium.org

BUG=611181
Committed: https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f
Cr-Commit-Position: refs/heads/master@{#401332}

[Sergey Ulanov, 2016-06-21 21:47:31]

https://codereview.chromium.org/2084123002/diff/40001/remoting/client/audio_d...
File remoting/client/audio_decode_scheduler.cc (right):

https://codereview.chromium.org/2084123002/diff/40001/remoting/client/audio_d...
remoting/client/audio_decode_scheduler.cc:108: }
nit: this can be moved to the previous line (clang-format is supposed to do
that)

https://codereview.chromium.org/2084123002/diff/40001/remoting/client/fake_au...
File remoting/client/fake_audio_consumer.h (right):

https://codereview.chromium.org/2084123002/diff/40001/remoting/client/fake_au...
remoting/client/fake_audio_consumer.h:26: int AddAudioPacket_count;
Please make this private, call it packets_received_ or packets_consumer_ and add
a public get methods, e.g.:
  int packets_received() { return packets_received_; }

Or potentially it may be useful to store packet content as well.

This counter is not used in this CL, so maybe just remove it for now?

[Sergey Ulanov, 2016-06-21 22:21:59]

lgtm

[nicholss, 2016-06-22 17:31:41]

The CQ bit was checked by nicholss@chromium.org

[commit-bot: I haz the power, 2016-06-22 17:32:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084123002/60001

[commit-bot: I haz the power, 2016-06-22 17:39:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-22 17:41:26]

Description was changed from

==========
Adding an interface to allow extension of the audio player for CRD and iOS.

This CL changes the audio player for CRD into a consumer of audio packets. The
choice of consumer is based on a consumer/provider pattern, the intent is to
create a new class that will be used in iOS in a following CL that acts as a
middle buffer between the CRD Client and the iOS audio player which will extend
both AudioConsumer and AudioProvider(not in this CL). Because of this change, I
needed the current usage of audio player to extend from a more generic interface
(AudioConsumer) which could apply to either this future buffer or audio player.

This is a followup to https://codereview.chromium.org/2052723002, I missed the
last upload for the CL changes.

R=sergeyu@chromium.org

BUG=611181
==========

to

==========
Adding an interface to allow extension of the audio player for CRD and iOS.

This CL changes the audio player for CRD into a consumer of audio packets. The
choice of consumer is based on a consumer/provider pattern, the intent is to
create a new class that will be used in iOS in a following CL that acts as a
middle buffer between the CRD Client and the iOS audio player which will extend
both AudioConsumer and AudioProvider(not in this CL). Because of this change, I
needed the current usage of audio player to extend from a more generic interface
(AudioConsumer) which could apply to either this future buffer or audio player.

This is a followup to https://codereview.chromium.org/2052723002, I missed the
last upload for the CL changes.

R=sergeyu@chromium.org

BUG=611181

Committed: https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f
Cr-Commit-Position: refs/heads/master@{#401332}
==========

[commit-bot: I haz the power, 2016-06-22 17:41:27]

Patchset 4 (id:??) landed as
https://crrev.com/79d9f91451cbec77bbd6bfbba95ba6da3bc8908f
Cr-Commit-Position: refs/heads/master@{#401332}