Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: remoting/client/audio_decode_scheduler_unittest.cc

Issue 2084123002: Adding an interface to allow extension of the audio player for CRD and iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing unused counter in fake audio consumer. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/audio_decode_scheduler.cc ('k') | remoting/client/audio_player.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/audio_decode_scheduler_unittest.cc
diff --git a/remoting/client/audio_decode_scheduler_unittest.cc b/remoting/client/audio_decode_scheduler_unittest.cc
index 2e252ed2276529dd505b30f2d4626492d65e4810..4a46b97ca0e26f47f1a3977409b56c7596ff0e7a 100644
--- a/remoting/client/audio_decode_scheduler_unittest.cc
+++ b/remoting/client/audio_decode_scheduler_unittest.cc
@@ -2,14 +2,16 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "remoting/client/audio_decode_scheduler.h"
+
#include "base/bind.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/threading/thread.h"
#include "remoting/base/auto_thread.h"
#include "remoting/base/auto_thread_task_runner.h"
-#include "remoting/client/audio_decode_scheduler.h"
#include "remoting/client/fake_audio_consumer.h"
+#include "remoting/proto/audio.pb.h"
#include "remoting/protocol/session_config.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -53,8 +55,8 @@ void AudioDecodeSchedulerTest::TearDown() {
run_loop_.Run();
}
-// TODO(nicholss) could share the following in a common class for use
-// other places.
+// TODO(nicholss): Could share the following in a common class for use
+// in other places.
std::unique_ptr<AudioPacket> CreatePacketWithSamplingRate_(
AudioPacket::SamplingRate rate,
int samples) {
@@ -95,6 +97,8 @@ TEST_F(AudioDecodeSchedulerTest, Shutdown) {
audio_scheduler.reset();
audio_consumer.reset();
+ // TODO(nicholss): This test does not really test anything. Add a way to get
+ // a count of the calls to AddAudioPacket.
}
} // namespace remoting
« no previous file with comments | « remoting/client/audio_decode_scheduler.cc ('k') | remoting/client/audio_player.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698