Adding an interface to allow extension of the audio player for CRD and iOS.

remoting/client/audio_decode_scheduler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/audio_decode_scheduler.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/single_thread_task_runner.h"
 #include "remoting/client/audio_consumer.h"
 #include "remoting/codec/audio_decoder.h"
 #include "remoting/proto/audio.pb.h"
 
 namespace remoting {
 
 class AudioDecodeScheduler::Core : public base::RefCountedThreadSafe<Core> {
  public:
   Core(scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
        scoped_refptr<base::SingleThreadTaskRunner> audio_decode_task_runner,
        base::WeakPtr<AudioConsumer> audio_consumer);
 
   void Initialize(const protocol::SessionConfig& config);
   void ProcessAudioPacket(std::unique_ptr<AudioPacket> packet,
                           const base::Closure& done);
 
-  // Called by AudioDecodeScheduler when it is destroyed.
-  void Detach();
-
  private:
   friend class base::RefCountedThreadSafe<Core>;
 
   virtual ~Core();
 
   // Called on the audio decoder thread.
   void DecodePacket(std::unique_ptr<AudioPacket> packet,
                     const base::Closure& done);
 
   // Called on the main thread.
@@ skipping 26 matching lines @@
 
 void AudioDecodeScheduler::Core::ProcessAudioPacket(
     std::unique_ptr<AudioPacket> packet,
     const base::Closure& done) {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
   audio_decode_task_runner_->PostTask(FROM_HERE, base::Bind(
       &AudioDecodeScheduler::Core::DecodePacket, this,
       base::Passed(&packet), done));
 }
 
-void AudioDecodeScheduler::Core::Detach() {
-  DCHECK(main_task_runner_->BelongsToCurrentThread());
-  // TODO(nicholss) No work to do anymore. Remove this?
-}
-
 void AudioDecodeScheduler::Core::DecodePacket(
     std::unique_ptr<AudioPacket> packet,
     const base::Closure& done) {
   DCHECK(audio_decode_task_runner_->BelongsToCurrentThread());
   std::unique_ptr<AudioPacket> decoded_packet =
       decoder_->Decode(std::move(packet));
 
   main_task_runner_->PostTask(FROM_HERE, base::Bind(
       &AudioDecodeScheduler::Core::ProcessDecodedPacket, this,
       base::Passed(&decoded_packet), done));
@@ skipping 12 matching lines @@
 
 AudioDecodeScheduler::AudioDecodeScheduler(
     scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
     scoped_refptr<base::SingleThreadTaskRunner> audio_decode_task_runner,
     base::WeakPtr<AudioConsumer> audio_consumer)
     : core_(new Core(main_task_runner,
                      audio_decode_task_runner,
                      audio_consumer)) {}
 
 AudioDecodeScheduler::~AudioDecodeScheduler() {
-  core_->Detach();
 }

[Sergey Ulanov, 2016/06/21 21:47:31]

nit: this can be moved to the previous line (clang-format is supposed to do
that)

 
 void AudioDecodeScheduler::Initialize(const protocol::SessionConfig& config) {
   core_->Initialize(config);
 }
 
 void AudioDecodeScheduler::ProcessAudioPacket(
     std::unique_ptr<AudioPacket> packet,
     const base::Closure& done) {
   core_->ProcessAudioPacket(std::move(packet), done);
 }
 
 }  // namespace remoting