Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 20831003: Never define 'DEBUG' for non-v8 code (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Never define 'DEBUG' for non-v8 code R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/standalone.gypi View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-01 09:09:01 UTC) #1
Jakob Kummerow
lgtm
7 years, 4 months ago (2013-08-01 09:44:43 UTC) #2
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-01 19:20:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16012 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698