build/standalone.gypi - Issue 20831003: Never define 'DEBUG' for non-v8 code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/standalone.gypi

Issue 20831003: Never define 'DEBUG' for non-v8 code (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/standalone.gypi

diff --git a/build/standalone.gypi b/build/standalone.gypi

index ab2dfd528e4862abbfde11c98c9384be7c5950cb..5c017d5f5073986935c3502642588c68d435b629 100644

--- a/build/standalone.gypi

+++ b/build/standalone.gypi

@@ -120,6 +120,9 @@

'target_conditions': [

['v8_code == 0', {

+ 'defines!': [

+ 'DEBUG',

+ ],

'conditions': [

['os_posix == 1 and OS != "mac"', {

'cflags!': [

@@ -132,9 +135,6 @@

}],

['OS == "win"', {

- 'defines!': [

- 'DEBUG',

- ],

'msvs_settings': {

'VCCLCompilerTool': {

'WarnAsError': 'false',

« no previous file with comments | « no previous file | no next file » | no next file with comments »