Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: build/standalone.gypi

Issue 20831003: Never define 'DEBUG' for non-v8 code (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 'configurations': { 113 'configurations': {
114 'Debug': { 114 'Debug': {
115 'cflags': [ '-g', '-O0' ], 115 'cflags': [ '-g', '-O0' ],
116 }, 116 },
117 'Release': { 117 'Release': {
118 # Xcode insists on this empty entry. 118 # Xcode insists on this empty entry.
119 }, 119 },
120 }, 120 },
121 'target_conditions': [ 121 'target_conditions': [
122 ['v8_code == 0', { 122 ['v8_code == 0', {
123 'defines!': [
124 'DEBUG',
125 ],
123 'conditions': [ 126 'conditions': [
124 ['os_posix == 1 and OS != "mac"', { 127 ['os_posix == 1 and OS != "mac"', {
125 'cflags!': [ 128 'cflags!': [
126 '-Werror', 129 '-Werror',
127 ], 130 ],
128 }], 131 }],
129 ['OS == "mac"', { 132 ['OS == "mac"', {
130 'xcode_settings': { 133 'xcode_settings': {
131 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO', # -Werror 134 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO', # -Werror
132 }, 135 },
133 }], 136 }],
134 ['OS == "win"', { 137 ['OS == "win"', {
135 'defines!': [
136 'DEBUG',
137 ],
138 'msvs_settings': { 138 'msvs_settings': {
139 'VCCLCompilerTool': { 139 'VCCLCompilerTool': {
140 'WarnAsError': 'false', 140 'WarnAsError': 'false',
141 }, 141 },
142 }, 142 },
143 }], 143 }],
144 ], 144 ],
145 }], 145 }],
146 ], 146 ],
147 }, 147 },
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 }, 276 },
277 'target_conditions': [ 277 'target_conditions': [
278 ['_type!="static_library"', { 278 ['_type!="static_library"', {
279 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-search_paths_first']}, 279 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-search_paths_first']},
280 }], 280 }],
281 ], # target_conditions 281 ], # target_conditions
282 }, # target_defaults 282 }, # target_defaults
283 }], # OS=="mac" 283 }], # OS=="mac"
284 ], 284 ],
285 } 285 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698