Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2082993002: [turbofan] Address the useless overflow bit materialization. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Address the useless overflow bit materialization. Add control dependencies to Projection and Int32Add/SubWithOverflow operators, to prevent the scheduler from moving the Projection nodes into the wrong place. This way the instruction selection can combine the Int32Add/SubWithOverflow operations with the DeoptimizeIf and/or DeoptimizeUnless nodes. This needs new operators CheckedInt32Add and CheckedInt32Sub so that we can delay the actual lowering until the effect/control linearizer. This also makes CheckIf operator obsolete, so we can drop it. R=jarin@chromium.org Committed: https://crrev.com/00889cc29c1489a8d00b4bfbef47b48efc45af5d Cr-Commit-Position: refs/heads/master@{#37148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -140 lines) Patch
M src/compiler/common-operator.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/effect-control-linearizer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 8 chunks +57 lines, -21 lines 0 comments Download
M src/compiler/int64-lowering.cc View 7 chunks +28 lines, -14 lines 0 comments Download
M src/compiler/machine-operator.cc View 5 chunks +21 lines, -6 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M src/compiler/simplified-operator.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 6 chunks +23 lines, -32 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 9 chunks +26 lines, -20 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 3 chunks +24 lines, -16 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-21 12:25:59 UTC) #1
Jarin
lgtm
4 years, 6 months ago (2016-06-21 12:32:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082993002/1
4 years, 6 months ago (2016-06-21 12:42:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_TIMED_OUT, no build URL)
4 years, 6 months ago (2016-06-21 14:26:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082993002/1
4 years, 6 months ago (2016-06-21 15:30:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 15:46:21 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 15:46:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00889cc29c1489a8d00b4bfbef47b48efc45af5d
Cr-Commit-Position: refs/heads/master@{#37148}

Powered by Google App Engine
This is Rietveld 408576698