Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: src/compiler/simplified-lowering.cc

Issue 2082993002: [turbofan] Address the useless overflow bit materialization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/representation-change.cc ('k') | src/compiler/simplified-operator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/simplified-lowering.cc
diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc
index ac0f53af9d0c686483d3c8d2c4d77f4a6f9e6f0a..2802ceebe530916eba1ef328f5f848f1a2b101ad 100644
--- a/src/compiler/simplified-lowering.cc
+++ b/src/compiler/simplified-lowering.cc
@@ -1091,16 +1091,8 @@ class RepresentationSelector {
NodeProperties::ChangeOp(node, new_op);
}
- void ChangeToInt32OverflowOp(Node* node, const Operator* op) {
- Node* effect = NodeProperties::GetEffectInput(node);
- Node* control = NodeProperties::GetControlInput(node);
- Node* arith = graph()->NewNode(op, node->InputAt(0), node->InputAt(1));
- Node* overflow = graph()->NewNode(common()->Projection(1), arith);
- effect =
- graph()->NewNode(simplified()->CheckIf(), overflow, effect, control);
- Node* value = graph()->NewNode(common()->Projection(0), arith);
- ReplaceEffectControlUses(node, effect, control);
- DeferReplacement(node, value);
+ void ChangeToInt32OverflowOp(Node* node, const Operator* new_op) {
+ NodeProperties::ChangeOp(node, new_op);
}
void VisitSpeculativeAdditiveOp(Node* node, Truncation truncation,
@@ -2028,6 +2020,8 @@ class RepresentationSelector {
case IrOpcode::kChangeFloat64ToUint32:
case IrOpcode::kTruncateInt64ToInt32:
case IrOpcode::kChangeFloat32ToFloat64:
+ case IrOpcode::kCheckedInt32Add:
+ case IrOpcode::kCheckedInt32Sub:
case IrOpcode::kCheckedUint32ToInt32:
case IrOpcode::kCheckedFloat64ToInt32:
case IrOpcode::kCheckedTaggedToInt32:
« no previous file with comments | « src/compiler/representation-change.cc ('k') | src/compiler/simplified-operator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698