Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/compiler/verifier.cc

Issue 2082993002: [turbofan] Address the useless overflow bit materialization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/compiler/wasm-compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 CheckNotTyped(node); 271 CheckNotTyped(node);
272 break; 272 break;
273 case IrOpcode::kLoop: 273 case IrOpcode::kLoop:
274 case IrOpcode::kMerge: 274 case IrOpcode::kMerge:
275 CHECK_EQ(control_count, input_count); 275 CHECK_EQ(control_count, input_count);
276 // Type is empty. 276 // Type is empty.
277 CheckNotTyped(node); 277 CheckNotTyped(node);
278 break; 278 break;
279 case IrOpcode::kDeoptimizeIf: 279 case IrOpcode::kDeoptimizeIf:
280 case IrOpcode::kDeoptimizeUnless: 280 case IrOpcode::kDeoptimizeUnless:
281 case IrOpcode::kCheckIf:
282 // Type is empty. 281 // Type is empty.
283 CheckNotTyped(node); 282 CheckNotTyped(node);
284 break; 283 break;
285 case IrOpcode::kDeoptimize: 284 case IrOpcode::kDeoptimize:
286 case IrOpcode::kReturn: 285 case IrOpcode::kReturn:
287 case IrOpcode::kThrow: 286 case IrOpcode::kThrow:
288 // Deoptimize, Return and Throw uses are End. 287 // Deoptimize, Return and Throw uses are End.
289 for (const Node* use : node->uses()) { 288 for (const Node* use : node->uses()) {
290 CHECK_EQ(IrOpcode::kEnd, use->opcode()); 289 CHECK_EQ(IrOpcode::kEnd, use->opcode());
291 } 290 }
(...skipping 657 matching lines...) Expand 10 before | Expand all | Expand 10 after
949 break; 948 break;
950 case IrOpcode::kCheckTaggedSigned: 949 case IrOpcode::kCheckTaggedSigned:
951 CheckValueInputIs(node, 0, Type::Any()); 950 CheckValueInputIs(node, 0, Type::Any());
952 CheckUpperIs(node, Type::TaggedSigned()); 951 CheckUpperIs(node, Type::TaggedSigned());
953 break; 952 break;
954 case IrOpcode::kCheckTaggedPointer: 953 case IrOpcode::kCheckTaggedPointer:
955 CheckValueInputIs(node, 0, Type::Any()); 954 CheckValueInputIs(node, 0, Type::Any());
956 CheckUpperIs(node, Type::TaggedPointer()); 955 CheckUpperIs(node, Type::TaggedPointer());
957 break; 956 break;
958 957
958 case IrOpcode::kCheckedInt32Add:
959 case IrOpcode::kCheckedInt32Sub:
959 case IrOpcode::kCheckedUint32ToInt32: 960 case IrOpcode::kCheckedUint32ToInt32:
960 case IrOpcode::kCheckedFloat64ToInt32: 961 case IrOpcode::kCheckedFloat64ToInt32:
961 case IrOpcode::kCheckedTaggedToInt32: 962 case IrOpcode::kCheckedTaggedToInt32:
962 case IrOpcode::kCheckedTaggedToFloat64: 963 case IrOpcode::kCheckedTaggedToFloat64:
963 break; 964 break;
964 965
965 case IrOpcode::kCheckFloat64Hole: 966 case IrOpcode::kCheckFloat64Hole:
966 CheckValueInputIs(node, 0, Type::Number()); 967 CheckValueInputIs(node, 0, Type::Number());
967 CheckUpperIs(node, Type::Number()); 968 CheckUpperIs(node, Type::Number());
968 break; 969 break;
(...skipping 517 matching lines...) Expand 10 before | Expand all | Expand 10 after
1486 replacement->op()->EffectOutputCount() > 0); 1487 replacement->op()->EffectOutputCount() > 0);
1487 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1488 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1488 replacement->opcode() == IrOpcode::kFrameState); 1489 replacement->opcode() == IrOpcode::kFrameState);
1489 } 1490 }
1490 1491
1491 #endif // DEBUG 1492 #endif // DEBUG
1492 1493
1493 } // namespace compiler 1494 } // namespace compiler
1494 } // namespace internal 1495 } // namespace internal
1495 } // namespace v8 1496 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | src/compiler/wasm-compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698