Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2956)

Unified Diff: appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py

Issue 2082903002: [Findit] Pass compile_targets as build_parameter (Findit side change). (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/waterfall/schedule_try_job_pipeline.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py b/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
index 31dfd13907eaa86c6b4460702d1579b5b8501709..8f124aa9e46bc2b6ffa513fdcc09630c20d4200e 100644
--- a/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
+++ b/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
@@ -29,7 +29,6 @@ class ScheduleTryjobPipelineTest(wf_testcase.WaterfallTestCase):
master_name = 'm'
builder_name = 'b'
build_number = 1
- compile_targets = ['a.exe']
expected_properties = {
'recipe': 'findit/chromium/compile',
@@ -37,15 +36,13 @@ class ScheduleTryjobPipelineTest(wf_testcase.WaterfallTestCase):
'bad_revision': 2,
'target_mastername': master_name,
'target_buildername': 'b',
- 'compile_targets': compile_targets,
'referenced_build_url': ('https://build.chromium.org/p/%s/builders'
'/%s/builds/%s') % (
master_name, builder_name, build_number)
}
try_job_pipeline = ScheduleTryJobPipeline()
properties = try_job_pipeline._GetBuildProperties(
- master_name, builder_name, build_number, 1, 2, TryJobType.COMPILE,
- compile_targets, None)
+ master_name, builder_name, build_number, 1, 2, TryJobType.COMPILE, None)
self.assertEqual(properties, expected_properties)
@@ -66,8 +63,7 @@ class ScheduleTryjobPipelineTest(wf_testcase.WaterfallTestCase):
}
try_job_pipeline = ScheduleTryJobPipeline()
properties = try_job_pipeline._GetBuildProperties(
- master_name, builder_name, build_number, 1, 2, TryJobType.TEST,
- None, None)
+ master_name, builder_name, build_number, 1, 2, TryJobType.TEST, None)
self.assertEqual(properties, expected_properties)
« no previous file with comments | « appengine/findit/waterfall/schedule_try_job_pipeline.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698