Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py

Issue 2082903002: [Findit] Pass compile_targets as build_parameter (Findit side change). (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/findit/waterfall/schedule_try_job_pipeline.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from common.waterfall import buildbucket_client 5 from common.waterfall import buildbucket_client
6 from model.wf_try_job import WfTryJob 6 from model.wf_try_job import WfTryJob
7 from model.wf_try_job_data import WfTryJobData 7 from model.wf_try_job_data import WfTryJobData
8 from waterfall.schedule_try_job_pipeline import ScheduleTryJobPipeline 8 from waterfall.schedule_try_job_pipeline import ScheduleTryJobPipeline
9 from waterfall.test import wf_testcase 9 from waterfall.test import wf_testcase
10 from waterfall.try_job_type import TryJobType 10 from waterfall.try_job_type import TryJobType
(...skipping 11 matching lines...) Expand all
22 else: 22 else:
23 results.append(( 23 results.append((
24 None, buildbucket_client.BuildbucketBuild(response['build']))) 24 None, buildbucket_client.BuildbucketBuild(response['build'])))
25 return results 25 return results
26 self.mock(buildbucket_client, 'TriggerTryJobs', MockedTriggerTryJobs) 26 self.mock(buildbucket_client, 'TriggerTryJobs', MockedTriggerTryJobs)
27 27
28 def testGetBuildPropertiesWithCompileTargets(self): 28 def testGetBuildPropertiesWithCompileTargets(self):
29 master_name = 'm' 29 master_name = 'm'
30 builder_name = 'b' 30 builder_name = 'b'
31 build_number = 1 31 build_number = 1
32 compile_targets = ['a.exe']
33 32
34 expected_properties = { 33 expected_properties = {
35 'recipe': 'findit/chromium/compile', 34 'recipe': 'findit/chromium/compile',
36 'good_revision': 1, 35 'good_revision': 1,
37 'bad_revision': 2, 36 'bad_revision': 2,
38 'target_mastername': master_name, 37 'target_mastername': master_name,
39 'target_buildername': 'b', 38 'target_buildername': 'b',
40 'compile_targets': compile_targets,
41 'referenced_build_url': ('https://build.chromium.org/p/%s/builders' 39 'referenced_build_url': ('https://build.chromium.org/p/%s/builders'
42 '/%s/builds/%s') % ( 40 '/%s/builds/%s') % (
43 master_name, builder_name, build_number) 41 master_name, builder_name, build_number)
44 } 42 }
45 try_job_pipeline = ScheduleTryJobPipeline() 43 try_job_pipeline = ScheduleTryJobPipeline()
46 properties = try_job_pipeline._GetBuildProperties( 44 properties = try_job_pipeline._GetBuildProperties(
47 master_name, builder_name, build_number, 1, 2, TryJobType.COMPILE, 45 master_name, builder_name, build_number, 1, 2, TryJobType.COMPILE, None)
48 compile_targets, None)
49 46
50 self.assertEqual(properties, expected_properties) 47 self.assertEqual(properties, expected_properties)
51 48
52 def testGetBuildPropertiesForTestFailure(self): 49 def testGetBuildPropertiesForTestFailure(self):
53 master_name = 'm' 50 master_name = 'm'
54 builder_name = 'b' 51 builder_name = 'b'
55 build_number = 1 52 build_number = 1
56 53
57 expected_properties = { 54 expected_properties = {
58 'recipe': 'findit/chromium/test', 55 'recipe': 'findit/chromium/test',
59 'good_revision': 1, 56 'good_revision': 1,
60 'bad_revision': 2, 57 'bad_revision': 2,
61 'target_mastername': master_name, 58 'target_mastername': master_name,
62 'target_testername': 'b', 59 'target_testername': 'b',
63 'referenced_build_url': ('https://build.chromium.org/p/%s/builders' 60 'referenced_build_url': ('https://build.chromium.org/p/%s/builders'
64 '/%s/builds/%s') % ( 61 '/%s/builds/%s') % (
65 master_name, builder_name, build_number) 62 master_name, builder_name, build_number)
66 } 63 }
67 try_job_pipeline = ScheduleTryJobPipeline() 64 try_job_pipeline = ScheduleTryJobPipeline()
68 properties = try_job_pipeline._GetBuildProperties( 65 properties = try_job_pipeline._GetBuildProperties(
69 master_name, builder_name, build_number, 1, 2, TryJobType.TEST, 66 master_name, builder_name, build_number, 1, 2, TryJobType.TEST, None)
70 None, None)
71 67
72 self.assertEqual(properties, expected_properties) 68 self.assertEqual(properties, expected_properties)
73 69
74 def testSuccessfullyScheduleNewTryJobForCompileWithSuspectedRevisions(self): 70 def testSuccessfullyScheduleNewTryJobForCompileWithSuspectedRevisions(self):
75 master_name = 'm' 71 master_name = 'm'
76 builder_name = 'b' 72 builder_name = 'b'
77 build_number = 223 73 build_number = 223
78 good_revision = 'rev1' 74 good_revision = 'rev1'
79 bad_revision = 'rev2' 75 bad_revision = 'rev2'
80 build_id = '1' 76 build_id = '1'
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 try_job_data = WfTryJobData.Get(try_job_id) 142 try_job_data = WfTryJobData.Get(try_job_id)
147 self.assertEqual(try_job_id, build_id) 143 self.assertEqual(try_job_id, build_id)
148 self.assertEqual(try_job.test_results[-1]['try_job_id'], build_id) 144 self.assertEqual(try_job.test_results[-1]['try_job_id'], build_id)
149 self.assertIsNotNone(try_job_data) 145 self.assertIsNotNone(try_job_data)
150 self.assertEqual(try_job_data.master_name, master_name) 146 self.assertEqual(try_job_data.master_name, master_name)
151 self.assertEqual(try_job_data.builder_name, builder_name) 147 self.assertEqual(try_job_data.builder_name, builder_name)
152 self.assertEqual(try_job_data.build_number, build_number) 148 self.assertEqual(try_job_data.build_number, build_number)
153 self.assertEqual(try_job_data.try_job_type, TryJobType.TEST) 149 self.assertEqual(try_job_data.try_job_type, TryJobType.TEST)
154 self.assertFalse(try_job_data.has_compile_targets) 150 self.assertFalse(try_job_data.has_compile_targets)
155 self.assertFalse(try_job_data.has_heuristic_results) 151 self.assertFalse(try_job_data.has_heuristic_results)
OLDNEW
« no previous file with comments | « appengine/findit/waterfall/schedule_try_job_pipeline.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698