Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1881)

Unified Diff: appengine/findit/waterfall/schedule_try_job_pipeline.py

Issue 2082903002: [Findit] Pass compile_targets as build_parameter (Findit side change). (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/schedule_try_job_pipeline.py
diff --git a/appengine/findit/waterfall/schedule_try_job_pipeline.py b/appengine/findit/waterfall/schedule_try_job_pipeline.py
index 77b4ccebc5289c8602857ead4d874951ce35a754..a195c5d4f6e00fbe6658077ce8ed77cd3a073b5c 100644
--- a/appengine/findit/waterfall/schedule_try_job_pipeline.py
+++ b/appengine/findit/waterfall/schedule_try_job_pipeline.py
@@ -17,7 +17,7 @@ class ScheduleTryJobPipeline(BasePipeline):
def _GetBuildProperties(
self, master_name, builder_name, build_number, good_revision,
- bad_revision, try_job_type, compile_targets, suspected_revisions):
+ bad_revision, try_job_type, suspected_revisions):
properties = {
'recipe': 'findit/chromium/%s' % try_job_type,
'good_revision': good_revision,
@@ -29,8 +29,6 @@ class ScheduleTryJobPipeline(BasePipeline):
if try_job_type == TryJobType.COMPILE:
properties['target_buildername'] = builder_name
- if compile_targets:
- properties['compile_targets'] = compile_targets
else: # try_job_type is 'test'.
properties['target_testername'] = builder_name
@@ -50,10 +48,10 @@ class ScheduleTryJobPipeline(BasePipeline):
properties = self._GetBuildProperties(
master_name, builder_name, build_number, good_revision, bad_revision,
- try_job_type, compile_targets, suspected_revisions)
+ try_job_type, suspected_revisions)
if try_job_type == TryJobType.COMPILE:
- additional_parameters = {}
+ additional_parameters = {'compile_targets': compile_targets}
else:
additional_parameters = {'tests': targeted_tests}
« no previous file with comments | « no previous file | appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698