Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2082523002: [turbofan] Introduce CheckTaggedSigned and CheckTaggedPointer operators. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce CheckTaggedSigned and CheckTaggedPointer operators. These are used to check for Smi or HeapObject, and we use them appropriately in JSNativeContextSpecialization, so we don't need to introduce dependencies on concrete control flow and/or concrete frame states. They will be optimized by a proper check elimination reducer, which will be added in a separate CL. R=jarin@chromium.org BUG=v8:4470 Committed: https://crrev.com/99eb5686e9833b95e10d084e6baf294c9e99cf1d Cr-Commit-Position: refs/heads/master@{#37096}

Patch Set 1 #

Patch Set 2 : Fix speculative operator bits #

Patch Set 3 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -127 lines) Patch
M src/compiler/common-operator.h View 2 chunks +15 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 4 chunks +46 lines, -2 lines 0 comments Download
M src/compiler/effect-control-linearizer.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 4 chunks +54 lines, -3 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 6 chunks +17 lines, -25 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 2 5 chunks +41 lines, -34 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/operator.h View 1 chunk +10 lines, -10 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 3 chunks +28 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 10 chunks +48 lines, -34 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 chunk +18 lines, -7 lines 0 comments Download
M test/unittests/compiler/escape-analysis-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 4 chunks +8 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-20 09:49:21 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the patch we were cooking. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-06-20 09:50:05 UTC) #2
Jarin
lgtm
4 years, 6 months ago (2016-06-20 09:55:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082523002/20001
4 years, 6 months ago (2016-06-20 09:55:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/9028)
4 years, 6 months ago (2016-06-20 09:58:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082523002/40001
4 years, 6 months ago (2016-06-20 10:25:25 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-20 10:46:21 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 10:49:02 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/99eb5686e9833b95e10d084e6baf294c9e99cf1d
Cr-Commit-Position: refs/heads/master@{#37096}

Powered by Google App Engine
This is Rietveld 408576698