src/compiler/wasm-compiler.cc - Issue 2082523002: [turbofan] Introduce CheckTaggedSigned and CheckTaggedPointer operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/wasm-compiler.cc

Issue 2082523002: [turbofan] Introduce CheckTaggedSigned and CheckTaggedPointer operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix compile Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/wasm-compiler.cc

diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc

index b0fc9cc64db8ab660c0ee2e64ce28d98e0d45b6d..09b05c972085d842ad832655e3ff38b238ce056e 100644

--- a/src/compiler/wasm-compiler.cc

+++ b/src/compiler/wasm-compiler.cc

@@ -2302,7 +2302,9 @@ Node* WasmGraphBuilder::BuildAllocateHeapNumberWithValue(Node* value,

Callable callable = CodeFactory::AllocateHeapNumber(jsgraph()->isolate());

Node* target = jsgraph()->HeapConstant(callable.code());

Node* context = jsgraph()->NoContextConstant();

- Node* effect = graph()->NewNode(common->BeginRegion(), graph()->start());

+ Node* effect =

+ graph()->NewNode(common->BeginRegion(RegionObservability::kNotObservable),

+ graph()->start());

if (!allocate_heap_number_operator_.is_set()) {

CallDescriptor* descriptor = Linkage::GetStubCallDescriptor(

jsgraph()->isolate(), jsgraph()->zone(), callable.descriptor(), 0,

« no previous file with comments | « src/compiler/verifier.cc ('k') | test/unittests/compiler/common-operator-unittest.cc » ('j') | no next file with comments »