Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2083503002: [turbofan] The speculative number operations don't produce control. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@JSNativeContextSpecialization_Check_Operators
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] The speculative number operations don't produce control. The simplified SpeculativeNumber operators shouldn't be in the control chain at all. They are part of the effect chain to ensure that we can find a frame state for eager deoptimization. R=jarin@chromium.org Committed: https://crrev.com/bfdaff315fe38d1cd65b54ea7535b75b5863703f Cr-Commit-Position: refs/heads/master@{#37098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/compiler/js-typed-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-20 10:33:06 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the change we talked about. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-06-20 10:33:35 UTC) #2
Jarin
lgtm
4 years, 6 months ago (2016-06-20 10:34:18 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2082523002 Patch 40001). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-20 10:34:30 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083503002/1
4 years, 6 months ago (2016-06-20 10:34:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083503002/1
4 years, 6 months ago (2016-06-20 10:53:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 11:00:36 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 11:03:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfdaff315fe38d1cd65b54ea7535b75b5863703f
Cr-Commit-Position: refs/heads/master@{#37098}

Powered by Google App Engine
This is Rietveld 408576698