Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 2082493002: Remove WebFrame::canHaveSecureChild (Closed)

Created:
3 years, 3 months ago by falken
Modified:
3 years, 3 months ago
Reviewers:
alexmos, dcheng
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, sof, tzik, mlamouri+watch-blink_chromium.org, eae+blinkwatch, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, blink-reviews-dom_chromium.org, dglazkov+blink, darin-cc_chromium.org, dcheng, blink-reviews, horo+watch_chromium.org, kinuko+watch, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, rwlbuis, Mike West
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebFrame::canHaveSecureChild To simplify the public API, ServiceWorkerNetworkProvider can do the parent walk itself. Follow-up to https://crrev.com/ad1850962644e19. BUG=607543 Committed: https://crrev.com/8353baf8d1504dbdd4ad7584ff2466de657521cd Cr-Commit-Position: refs/heads/master@{#400896}

Patch Set 1 #

Patch Set 2 : patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -98 lines) Patch
M content/child/service_worker/service_worker_network_provider.cc View 3 chunks +15 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.h View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrame.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
falken
PTAL
3 years, 3 months ago (2016-06-20 07:39:42 UTC) #2
dcheng
LGTM, thanks. In the long-term, I'm hoping we can update the spec definitions to make ...
3 years, 3 months ago (2016-06-20 15:06:39 UTC) #3
alexmos
LGTM
3 years, 3 months ago (2016-06-20 18:11:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082493002/1
3 years, 3 months ago (2016-06-20 22:35:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/203671) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
3 years, 3 months ago (2016-06-20 22:43:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082493002/20001
3 years, 3 months ago (2016-06-21 01:19:02 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/242165)
3 years, 3 months ago (2016-06-21 02:59:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082493002/20001
3 years, 3 months ago (2016-06-21 03:25:03 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 3 months ago (2016-06-21 04:50:48 UTC) #16
commit-bot: I haz the power
3 years, 3 months ago (2016-06-21 04:56:55 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8353baf8d1504dbdd4ad7584ff2466de657521cd
Cr-Commit-Position: refs/heads/master@{#400896}

Powered by Google App Engine
This is Rietveld 408576698