third_party/WebKit/Source/core/frame/Frame.cpp - Issue 2082493002: Remove WebFrame::canHaveSecureChild

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Frame.cpp

Issue 2082493002: Remove WebFrame::canHaveSecureChild (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: patch for landing Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/Frame.cpp

diff --git a/third_party/WebKit/Source/core/frame/Frame.cpp b/third_party/WebKit/Source/core/frame/Frame.cpp

index c612285dae80ac046b85595dad481d8f8efafce1..a27137994bda60db108cfd11f68552773da71ce8 100644

--- a/third_party/WebKit/Source/core/frame/Frame.cpp

+++ b/third_party/WebKit/Source/core/frame/Frame.cpp

@@ -304,15 +304,6 @@ void Frame::didChangeVisibilityState()

childFrames[i]->didChangeVisibilityState();

}

-bool Frame::canHaveSecureChild() const

- for (const Frame* parent = this; parent; parent = parent->tree().parent()) {

- if (!parent->securityContext()->getSecurityOrigin()->isPotentiallyTrustworthy())

- return false;

- }

- return true;

Frame::Frame(FrameClient* client, FrameHost* host, FrameOwner* owner)

: m_treeNode(this)

, m_host(host)