Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2079393006: Remove IsOrdinaryList; rename to OrdinaryList to List (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa_part_III
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove IsOrdinaryList; rename to OrdinaryList to List IsOrdinaryList is no longer used, removed. Rename list item as Ordinary doesn't hold any meaning. Committed: https://pdfium.googlesource.com/pdfium/+/a5c85987a7604c0915268cb694f03f3452fdac6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M xfa/fxfa/parser/xfa_basic_data.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 2 chunks +1 line, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-22 18:21:55 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-23 03:57:26 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2082343003 Patch 1). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-23 03:57:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079393006/1
4 years, 6 months ago (2016-06-23 14:56:26 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 14:56:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/a5c85987a7604c0915268cb694f03f3452fd...

Powered by Google App Engine
This is Rietveld 408576698