content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc - Issue 2082343002: Remove calls to deprecated MessageLoop methods in content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc

Issue 2082343002: Remove calls to deprecated MessageLoop methods in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc

diff --git a/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc b/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc

index 42ff212bf41759973e23bc4f773a24c13f1fc9f5..b2420845bba5a13ed12756a09cf637d612f884af 100644

--- a/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc

+++ b/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc

@@ -11,6 +11,7 @@

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

+#include "base/run_loop.h"

#include "build/build_config.h"

#include "content/browser/gamepad/gamepad_test_helpers.h"

#include "content/browser/renderer_host/pepper/browser_ppapi_host_test.h"

@@ -155,7 +156,7 @@ TEST_F(PepperGamepadHostTest, MAYBE_WaitForReply) {

fetcher->WaitForDataReadAndCallbacksIssued();

// It should not have sent the callback message.

- service_->message_loop().RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

EXPECT_EQ(0u, sink().message_count());

// Set a button down and wait for it to be read twice.

@@ -166,7 +167,7 @@ TEST_F(PepperGamepadHostTest, MAYBE_WaitForReply) {

fetcher->WaitForDataReadAndCallbacksIssued();

// It should have sent a callback.

- service_->message_loop().RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

ppapi::proxy::ResourceMessageReplyParams reply_params;

IPC::Message reply_msg;

ASSERT_TRUE(sink().GetFirstResourceReplyMatching(