Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2081863002: Revert of cc: Add mailbox support to ResourceProvider write locks. (Closed)

Created:
4 years, 6 months ago by sunnyps
Modified:
4 years, 6 months ago
Reviewers:
piman, reveman, vmpstr, vmiura, ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@worker_context_stream
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Add mailbox support to ResourceProvider write locks. (patchset #24 id:460001 of https://codereview.chromium.org/1951193002/ ) Reason for revert: Bug 621422, 621130 Some tasks can be completed twice which leads to crashes. Original issue's description: > cc: Add mailbox support to ResourceProvider write locks. > > This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox > requires using ScopedTextureProvider/ScopedSkSurfaceProvider which > ensures that the texture id for the mailbox is destroyed after use on > the worker context. > > This CL also includes the following cleanup: > 1. ResourceProvider locks don't keep resource pointers around. > 2. ScopedSamplerGL does not inherit from ScopedReadLockGL. > 3. GpuRasterizer is folded back into GpuRasterBufferProvider. > 4. TileTaskManager does not own RasterBufferProvider. > > BUG=525259 > R=piman@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2 > Committed: https://crrev.com/3b0f0b8d3db0a9f66864d5b7da87c82f49e74a29 > Cr-Original-Commit-Position: refs/heads/master@{#398204} > Cr-Commit-Position: refs/heads/master@{#399983} TBR=piman@chromium.org,reveman@chromium.org,vmiura@chromium.org,ericrk@chromium.org,vmpstr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=525259, 621422, 621130 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0 Cr-Commit-Position: refs/heads/master@{#400873}

Patch Set 1 #

Patch Set 2 : manual revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+670 lines, -799 lines) Patch
M cc/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M cc/raster/bitmap_raster_buffer_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/bitmap_raster_buffer_provider.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.h View 1 3 chunks +5 lines, -55 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.cc View 1 4 chunks +69 lines, -159 lines 0 comments Download
A cc/raster/gpu_rasterizer.h View 1 chunk +57 lines, -0 lines 0 comments Download
A cc/raster/gpu_rasterizer.cc View 1 1 chunk +86 lines, -0 lines 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.h View 1 7 chunks +5 lines, -45 lines 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.cc View 1 8 chunks +135 lines, -156 lines 0 comments Download
M cc/raster/raster_buffer_provider.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M cc/raster/raster_buffer_provider_perftest.cc View 1 10 chunks +17 lines, -30 lines 0 comments Download
M cc/raster/raster_buffer_provider_unittest.cc View 1 7 chunks +17 lines, -16 lines 0 comments Download
M cc/raster/zero_copy_raster_buffer_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/zero_copy_raster_buffer_provider.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/resource_provider.h View 1 5 chunks +46 lines, -68 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 17 chunks +128 lines, -176 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M cc/test/fake_raster_buffer_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_raster_buffer_provider.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M cc/test/fake_tile_manager.cc View 1 3 chunks +0 lines, -5 lines 0 comments Download
M cc/test/fake_tile_task_manager.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M cc/test/fake_tile_task_manager.cc View 1 2 chunks +11 lines, -1 line 0 comments Download
M cc/test/layer_tree_pixel_resource_test.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M cc/tiles/tile_manager.h View 1 4 chunks +2 lines, -6 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 9 chunks +14 lines, -36 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 1 2 chunks +12 lines, -7 lines 0 comments Download
M cc/tiles/tile_task_manager.h View 1 2 chunks +9 lines, -1 line 0 comments Download
M cc/tiles/tile_task_manager.cc View 1 2 chunks +16 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 5 chunks +8 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
sunnyps
Created Revert of cc: Add mailbox support to ResourceProvider write locks.
4 years, 6 months ago (2016-06-21 00:10:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081863002/1
4 years, 6 months ago (2016-06-21 00:11:21 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/23885) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-21 00:13:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2081863002/310001
4 years, 6 months ago (2016-06-21 00:56:45 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:310001)
4 years, 6 months ago (2016-06-21 01:58:05 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 02:01:42 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/12074d3d1ac750fb170355f503d160f48cfefed0
Cr-Commit-Position: refs/heads/master@{#400873}

Powered by Google App Engine
This is Rietveld 408576698