Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 2081603003: Add UMA for Quick View (file type and volume type). (Closed)

Created:
4 years, 6 months ago by oka
Modified:
4 years, 4 months ago
Reviewers:
fukino, Steven Holte
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA for Quick View (file type and volume type). FileBrowser.QuickView.FileType - File type shown in Quick View. FileBrowser.QuickView.VolumeType - Volume type where Quick View is opened. BUG=627697 TEST=manually (using Linux, checked chrome://histograms.) Committed: https://crrev.com/3a0160731876cbef11d9d7a7365c33656599fd45 Cr-Commit-Position: refs/heads/master@{#409755}

Patch Set 1 #

Patch Set 2 : WIP: QuickView: Add UMA #

Patch Set 3 : nit #

Patch Set 4 : nit #

Patch Set 5 : Rebase. #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -6 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 3 4 2 chunks +10 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_tasks.js View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/main_scripts.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/quick_view_controller.js View 1 2 3 4 4 chunks +10 lines, -1 line 0 comments Download
A ui/file_manager/file_manager/foreground/js/quick_view_uma.js View 1 2 3 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (17 generated)
oka
nit
4 years, 4 months ago (2016-07-27 08:13:32 UTC) #4
oka
PTAL.
4 years, 4 months ago (2016-07-27 08:21:42 UTC) #9
fukino
lgtm
4 years, 4 months ago (2016-07-27 09:21:37 UTC) #11
oka
+holte@ for histograms.xml.
4 years, 4 months ago (2016-08-01 08:05:38 UTC) #13
oka
On 2016/08/01 08:05:38, oka wrote: > +holte@ for histograms.xml. holte, friendly ping.
4 years, 4 months ago (2016-08-02 00:11:20 UTC) #14
Steven Holte
lgtm
4 years, 4 months ago (2016-08-02 19:24:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2081603003/60001
4 years, 4 months ago (2016-08-02 23:05:21 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/45263) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-02 23:07:43 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2081603003/60001
4 years, 4 months ago (2016-08-03 09:17:51 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/105973) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-03 09:21:55 UTC) #23
oka
Rebase.
4 years, 4 months ago (2016-08-04 07:56:29 UTC) #24
oka
Rebase.
4 years, 4 months ago (2016-08-04 07:59:32 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2081603003/100001
4 years, 4 months ago (2016-08-04 08:59:57 UTC) #28
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 4 months ago (2016-08-04 10:16:36 UTC) #30
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 10:18:21 UTC) #32
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/3a0160731876cbef11d9d7a7365c33656599fd45
Cr-Commit-Position: refs/heads/master@{#409755}

Powered by Google App Engine
This is Rietveld 408576698