Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager.js

Issue 2081603003: Add UMA for Quick View (file type and volume type). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/file_manager.js
diff --git a/ui/file_manager/file_manager/foreground/js/file_manager.js b/ui/file_manager/file_manager/foreground/js/file_manager.js
index 2ac4b44ea34d736e58e7865f6ff0af1cb77ce29a..e711f470d9cafacf97a6bf6601eb8b6a37c6f4bd 100644
--- a/ui/file_manager/file_manager/foreground/js/file_manager.js
+++ b/ui/file_manager/file_manager/foreground/js/file_manager.js
@@ -266,6 +266,12 @@ function FileManager() {
this.columnVisibilityController_ = null;
/**
+ * @type {QuickViewUma}
+ * @private
+ */
+ this.quickViewUma_ = null;
+
+ /**
* @type {QuickViewController}
* @private
*/
@@ -557,12 +563,15 @@ FileManager.prototype = /** @struct */ {
chrome.commandLinePrivate.hasSwitch(
'disable-files-quick-view', function(disabled) {
if (!disabled) {
+ this.quickViewUma_ =
+ new QuickViewUma(assert(this.volumeManager_));
this.quickViewController_ = new QuickViewController(
quickView, assert(this.metadataModel_),
assert(this.selectionHandler_),
assert(this.ui_.listContainer), assert(this.quickViewModel_),
assert(this.taskController_),
- fileListSelectionModel);
+ fileListSelectionModel,
+ assert(this.quickViewUma_));
this.metadataBoxController_ = new MetadataBoxController(
this.metadataModel_, quickView.getFilesMetadataBox(),
quickView, this.quickViewModel_, this.fileMetadataFormatter_);

Powered by Google App Engine
This is Rietveld 408576698