ui/file_manager/file_manager/foreground/js/file_tasks.js - Issue 2081603003: Add UMA for Quick View (file type and volume type).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/file_tasks.js

Issue 2081603003: Add UMA for Quick View (file type and volume type). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/file_manager.js ('k') | ui/file_manager/file_manager/foreground/js/main_scripts.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/file_tasks.js

diff --git a/ui/file_manager/file_manager/foreground/js/file_tasks.js b/ui/file_manager/file_manager/foreground/js/file_tasks.js

index 64381415a7c780650743a6c8c32ea2e758acf08f..6ba5710b53e7eec805af716458510117bae8fb81 100644

--- a/ui/file_manager/file_manager/foreground/js/file_tasks.js

+++ b/ui/file_manager/file_manager/foreground/js/file_tasks.js

@@ -235,9 +235,8 @@ FileTasks.prototype.openSuggestAppsDialog = function(

* @const

* @type {Array<string>}

- * @private

-FileTasks.UMA_INDEX_KNOWN_EXTENSIONS_ = Object.freeze([

+FileTasks.UMA_INDEX_KNOWN_EXTENSIONS = Object.freeze([

'other', '.3ga', '.3gp', '.aac', '.alac', '.asf', '.avi', '.bmp', '.csv',

'.doc', '.docx', '.flac', '.gif', '.jpeg', '.jpg', '.log', '.m3u', '.m3u8',

'.m4a', '.m4v', '.mid', '.mkv', '.mov', '.mp3', '.mp4', '.mpg', '.odf',

@@ -277,11 +276,11 @@ FileTasks.recordViewingFileTypeUMA_ = function(entries) {

for (var i = 0; i < entries.length; i++) {

var entry = entries[i];

var extension = FileType.getExtension(entry).toLowerCase();

- if (FileTasks.UMA_INDEX_KNOWN_EXTENSIONS_.indexOf(extension) < 0) {

+ if (FileTasks.UMA_INDEX_KNOWN_EXTENSIONS.indexOf(extension) < 0) {

extension = 'other';

}

metrics.recordEnum(

- 'ViewingFileType', extension, FileTasks.UMA_INDEX_KNOWN_EXTENSIONS_);

+ 'ViewingFileType', extension, FileTasks.UMA_INDEX_KNOWN_EXTENSIONS);

}

};