Use GrShape in GrPathRenderer.

Use GrShape in GrPathRenderer.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2081383006

Committed: https://skia.googlesource.com/skia/+/8acedde5970ce70de6d9791ffeda87a65af4ed07

[bsalomon, 2016-06-23 20:24:29]

Description was changed from

==========
Use GrShape in GrPathRenderer.
==========

to

==========
Use GrShape in GrPathRenderer.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2081383006
==========

[bsalomon, 2016-06-23 20:32:03]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[robertphillips, 2016-06-24 12:43:29]

lgtm

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrPathRenderer.h
File src/gpu/GrPathRenderer.h (right):

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrPathRenderer....
src/gpu/GrPathRenderer.h:195: SkASSERT(fShape->style().isSimpleFill())
SkDEBUGCODE these next two lines ?

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrSWMaskHelper.cpp
File src/gpu/GrSWMaskHelper.cpp (right):

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrSWMaskHelper....
src/gpu/GrSWMaskHelper.cpp:13: #include "GrDrawContext.h"
only include once ?

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrSoftwarePathR...
File src/gpu/GrSoftwarePathRenderer.cpp (right):

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrSoftwarePathR...
src/gpu/GrSoftwarePathRenderer.cpp:128: 
stray ';' ?

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrSoftwarePathR...
src/gpu/GrSoftwarePathRenderer.cpp:132: const GrShape* shape = args.fShape;
Would it make any sense to resolve non-dashing path effects at the canvas level
so no lower code need worry about them?

[bsalomon, 2016-06-24 16:10:23]

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrPathRenderer.h
File src/gpu/GrPathRenderer.h (right):

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrPathRenderer....
src/gpu/GrPathRenderer.h:195: SkASSERT(fShape->style().isSimpleFill())
On 2016/06/24 12:43:29, robertphillips wrote:
> SkDEBUGCODE these next two lines ?

The calls are in SkDEBUGCODE. I'll put the whole function #ifdef SK_DEBUG to
make sure it never gets called in release.

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrSWMaskHelper.cpp
File src/gpu/GrSWMaskHelper.cpp (right):

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrSWMaskHelper....
src/gpu/GrSWMaskHelper.cpp:13: #include "GrDrawContext.h"
On 2016/06/24 12:43:29, robertphillips wrote:
> only include once ?

Sometimes you just want to be extra sure.
Sometimes you just want to be extra sure.

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrSoftwarePathR...
File src/gpu/GrSoftwarePathRenderer.cpp (right):

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrSoftwarePathR...
src/gpu/GrSoftwarePathRenderer.cpp:128: 
On 2016/06/24 12:43:29, robertphillips wrote:
> stray ';' ?

Done;

https://codereview.chromium.org/2081383006/diff/20001/src/gpu/GrSoftwarePathR...
src/gpu/GrSoftwarePathRenderer.cpp:132: const GrShape* shape = args.fShape;
On 2016/06/24 12:43:29, robertphillips wrote:
> Would it make any sense to resolve non-dashing path effects at the canvas
level
> so no lower code need worry about them?

Yep. I modified onCanDraw() to reject any shape that has style that applies.

[bsalomon, 2016-06-24 16:12:03]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-06-24 16:12:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2081383006/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-06-24 16:12:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 16:17:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 16:17:16]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
  Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bsalomon, 2016-06-24 16:18:25]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-06-24 16:18:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 16:22:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 16:22:10]

Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bsalomon, 2016-06-24 17:28:40]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-06-24 17:28:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 17:42:19]

Description was changed from

==========
Use GrShape in GrPathRenderer.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2081383006
==========

to

==========
Use GrShape in GrPathRenderer.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2081383006

Committed:
https://skia.googlesource.com/skia/+/8acedde5970ce70de6d9791ffeda87a65af4ed07
==========

[commit-bot: I haz the power, 2016-06-24 17:42:21]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8acedde5970ce70de6d9791ffeda87a65af4ed07