Remove style application from GrPathRenderer subclasses

Remove style application from GrPathRenderer subclasses

Now that GrPathRenderer is using GrShape it is possible to get a key for a path that was computed by applying style to an original path.

This improves path renderer subclass selection, particularly when a post-styled path happens to work with a simpler path renderer (e.g. it is convex). Previously a more expensive path renderer may have applied the style and rendered it (e.g. the distance field PR)


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064753003

Committed: https://skia.googlesource.com/skia/+/ee43241d72148545e4e3b75aa4338c491b39cc0c

[bsalomon, 2016-06-13 21:35:27]

Description was changed from

==========
e# Enter a description of the change.
start on removing style application from GrPR subclasses

BUG=skia:
==========

to

==========
e# Enter a description of the change.
start on removing style application from GrPR subclasses

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064753003
==========

[bsalomon, 2016-06-24 18:43:19]

Description was changed from

==========
e# Enter a description of the change.
start on removing style application from GrPR subclasses

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064753003
==========

to

==========
Remove style application from GrPathRenderer subclasses

Now that GrPathRenderer is using GrShape it is possible to get a key for a path
that was computed by applying style to an original path.

This improves path renderer subclass selection, particularly when a post-styled
path happens to work with a simpler path renderer (e.g. it is convex).
Previously a more expensive path renderer may have applied the style and
rendered it (e.g. the distance field PR)


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064753003
==========

[bsalomon, 2016-06-24 18:43:19]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[bsalomon, 2016-06-24 18:43:27]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 18:43:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 18:58:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 18:59:01]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-06-24 20:53:33]

https://codereview.chromium.org/2064753003/diff/40001/src/gpu/GrShape.cpp
File src/gpu/GrShape.cpp (right):

https://codereview.chromium.org/2064753003/diff/40001/src/gpu/GrShape.cpp#new...
src/gpu/GrShape.cpp:41: SkASSERT((Type::kPath == fType) ==
SkToBool(fPath.getMaybeNull()));
Ignore all these. I meant to delete these asserts.

[egdaniel, 2016-06-27 13:16:58]

https://codereview.chromium.org/2064753003/diff/40001/src/gpu/batches/GrAADis...
File src/gpu/batches/GrAADistanceFieldPathRenderer.cpp (right):

https://codereview.chromium.org/2064753003/diff/40001/src/gpu/batches/GrAADis...
src/gpu/batches/GrAADistanceFieldPathRenderer.cpp:97: if (!args.fAntiAlias ||
!args.fShape->style().isSimpleFill() ||args.fShape->inverseFilled()) {
space after ||

https://codereview.chromium.org/2064753003/diff/40001/src/gpu/batches/GrAADis...
File src/gpu/batches/GrAADistanceFieldPathRenderer.h (right):

https://codereview.chromium.org/2064753003/diff/40001/src/gpu/batches/GrAADis...
src/gpu/batches/GrAADistanceFieldPathRenderer.h:50: int shapeCnt =
shape.unstyledKeySize();
shapeCnt? maybe keySize or unstyledKeySize?

https://codereview.chromium.org/2064753003/diff/40001/src/gpu/batches/GrAADis...
src/gpu/batches/GrAADistanceFieldPathRenderer.h:65: // rendered size for stored
path (32x32 max, 64x64 max, 128x128 max)
I don't think this comment is clear that it refers to the dim in the key

[bsalomon, 2016-06-27 13:37:52]

https://codereview.chromium.org/2064753003/diff/40001/src/gpu/batches/GrAADis...
File src/gpu/batches/GrAADistanceFieldPathRenderer.cpp (right):

https://codereview.chromium.org/2064753003/diff/40001/src/gpu/batches/GrAADis...
src/gpu/batches/GrAADistanceFieldPathRenderer.cpp:97: if (!args.fAntiAlias ||
!args.fShape->style().isSimpleFill() ||args.fShape->inverseFilled()) {
On 2016/06/27 13:16:58, egdaniel wrote:
> space after ||

Done.

https://codereview.chromium.org/2064753003/diff/40001/src/gpu/batches/GrAADis...
File src/gpu/batches/GrAADistanceFieldPathRenderer.h (right):

https://codereview.chromium.org/2064753003/diff/40001/src/gpu/batches/GrAADis...
src/gpu/batches/GrAADistanceFieldPathRenderer.h:65: // rendered size for stored
path (32x32 max, 64x64 max, 128x128 max)
On 2016/06/27 13:16:58, egdaniel wrote:
> I don't think this comment is clear that it refers to the dim in the key

Done.

[egdaniel, 2016-06-27 13:39:02]

lgtm

[bsalomon, 2016-06-27 13:39:15]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 13:39:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsalomon, 2016-06-27 13:53:45]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-06-27 13:53:46]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/2064753003/#ps120001
(title: "Remove random style from DF batch test create, since it now only allows
simple fill")

[commit-bot: I haz the power, 2016-06-27 13:53:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 14:18:20]

Description was changed from

==========
Remove style application from GrPathRenderer subclasses

Now that GrPathRenderer is using GrShape it is possible to get a key for a path
that was computed by applying style to an original path.

This improves path renderer subclass selection, particularly when a post-styled
path happens to work with a simpler path renderer (e.g. it is convex).
Previously a more expensive path renderer may have applied the style and
rendered it (e.g. the distance field PR)


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064753003
==========

to

==========
Remove style application from GrPathRenderer subclasses

Now that GrPathRenderer is using GrShape it is possible to get a key for a path
that was computed by applying style to an original path.

This improves path renderer subclass selection, particularly when a post-styled
path happens to work with a simpler path renderer (e.g. it is convex).
Previously a more expensive path renderer may have applied the style and
rendered it (e.g. the distance field PR)


GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064753003

Committed:
https://skia.googlesource.com/skia/+/ee43241d72148545e4e3b75aa4338c491b39cc0c
==========

[commit-bot: I haz the power, 2016-06-27 14:18:21]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/ee43241d72148545e4e3b75aa4338c491b39cc0c