Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 2080513002: Deletes mojo::Callback (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
Reviewers:
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, ben+mojo_chromium.org, blink-reviews, blink-worker-reviews_chromium.org, cbentzel+watch_chromium.org, chasej+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dcheng, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, hidehiko+watch_chromium.org, horo+watch_chromium.org, iclelland+watch_chromium.org, jam, jkarlin+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, lhchavez+watch_chromium.org, mcasas+watch+vc_chromium.org, michaeln, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-geolocation_chromium.org, mlamouri+watch-content_chromium.org, Michael van Ouwerkerk, nhiroki, Peter Beverloo, piman+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, serviceworker-reviews, timvolodine, tzik, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deletes mojo::Callback Removes all references to mojo::Callback and mojo::Closure, replacing them with base::Callback or base::Closure, or where applicable a mojom-generated callback alias. The vast majority of the changes here are name changes only, as mojo::Callback is already an alias for base::Callback. Hence the TBRs. Also removes mojo/public/cpp/bindings/callback.h BUG=620840 TBR=ben@chromium.org for chrome, content, misc TBR=lhchavez@chromium.org for components/arc TBR=xhwang@chromium.org for media TBR=haraken@chromium.org for third_party/WebKit Committed: https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef Committed: https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99 Cr-Original-Commit-Position: refs/heads/master@{#400616} Cr-Commit-Position: refs/heads/master@{#400620}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -419 lines) Patch
M chrome/renderer/chrome_render_thread_observer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/utility/image_decoder_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/image_decoder_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/bluetooth/arc_bluetooth_bridge.h View 3 chunks +6 lines, -5 lines 0 comments Download
M components/arc/bluetooth/arc_bluetooth_bridge.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/arc/obb_mounter/arc_obb_mounter_bridge.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/directory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M components/mus/clipboard/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/clipboard/clipboard_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/window_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/window_surface.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/mus/ws/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/platform_display.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/server_window_surface.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/mus/ws/window_tree.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/mus/ws/window_tree.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/mus/ws/window_tree_client_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/battery_status/battery_monitor_integration_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/geolocation/geolocation_service_impl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/geolocation/geolocation_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/image_capture_impl.cc View 2 chunks +1 line, -8 lines 0 comments Download
M content/browser/permissions/permission_service_impl.h View 3 chunks +5 lines, -6 lines 0 comments Download
M content/browser/permissions/permission_service_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.h View 9 chunks +21 lines, -22 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 9 chunks +18 lines, -19 lines 0 comments Download
M content/browser/presentation/presentation_service_impl_unittest.cc View 13 chunks +13 lines, -13 lines 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/background_sync/background_sync_client_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/battery/battery_monitor_impl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M device/battery/battery_monitor_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/data_sink_receiver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/serial/data_sink_receiver.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M device/serial/serial_connection.h View 1 chunk +5 lines, -8 lines 0 comments Download
M device/serial/serial_connection.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M device/serial/serial_service_impl.h View 1 chunk +1 line, -3 lines 0 comments Download
M device/serial/serial_service_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M device/usb/mojo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/usb/mojo/device_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/usb/mojo/device_impl.cc View 7 chunks +9 lines, -32 lines 0 comments Download
M device/usb/mojo/device_manager_impl.h View 3 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/api/mime_handler_private/mime_handler_private.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/mime_handler_private/mime_handler_private.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M extensions/browser/mojo/stash_backend.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M media/capture/video/scoped_result_callback.h View 2 chunks +3 lines, -6 lines 0 comments Download
M media/capture/video/video_capture_device.h View 3 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/clients/mojo_demuxer_stream_impl.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M media/mojo/services/mojo_cdm_promise.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.h View 1 chunk +11 lines, -17 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.cc View 3 chunks +10 lines, -15 lines 0 comments Download
M media/mojo/services/mojo_decryptor_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_decryptor_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 4 chunks +8 lines, -7 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 7 chunks +10 lines, -11 lines 0 comments Download
M mojo/mojo_public.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 2 chunks +0 lines, -11 lines 0 comments Download
M mojo/public/cpp/bindings/associated_binding.h View 4 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/associated_interface_ptr.h View 4 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/binding.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/binding_set.h View 6 chunks +6 lines, -5 lines 0 comments Download
D mojo/public/cpp/bindings/callback.h View 1 chunk +0 lines, -19 lines 0 comments Download
M mojo/public/cpp/bindings/interface_ptr.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.h View 6 chunks +6 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_endpoint_client.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_state.h View 7 chunks +7 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/router.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/strong_binding.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/associated_interface_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/binding_callback_unittest.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/tests/bindings_perftest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/connector_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/tests/handle_passing_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/request_response_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sync_method_unittest.cc View 1 chunk +15 lines, -11 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_factory_mojo.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/shell/public/cpp/connection.h View 2 chunks +2 lines, -1 line 0 comments Download
M services/shell/public/cpp/lib/connection_impl.h View 3 chunks +3 lines, -2 lines 0 comments Download
M services/shell/public/cpp/lib/connection_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/shell_connection.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M services/user/user_shell_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/user/user_shell_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mojo/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mojo/MojoHelper.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080513002/20001
4 years, 6 months ago (2016-06-19 06:59:42 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-19 09:09:08 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3524eb5ef75b90527195d82f8b9cf3bd2cdf04ef Cr-Commit-Position: refs/heads/master@{#400616}
4 years, 6 months ago (2016-06-19 09:12:51 UTC) #7
Yuta Kitamura
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2080083002/ by yutak@chromium.org. ...
4 years, 6 months ago (2016-06-19 09:22:39 UTC) #8
Ken Rockot(use gerrit already)
On 2016/06/19 at 09:22:39, yutak wrote: > A revert of this CL (patchset #2 id:20001) ...
4 years, 6 months ago (2016-06-19 14:41:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080513002/40001
4 years, 6 months ago (2016-06-19 17:02:56 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-19 17:08:51 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-19 17:10:38 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a21316a36e7774327b4f05f62be2f9eda35e7c99
Cr-Commit-Position: refs/heads/master@{#400620}

Powered by Google App Engine
This is Rietveld 408576698