Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1394)

Unified Diff: media/mojo/services/mojo_renderer_service.cc

Issue 2080513002: Deletes mojo::Callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/mojo_renderer_service.h ('k') | mojo/mojo_public.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_renderer_service.cc
diff --git a/media/mojo/services/mojo_renderer_service.cc b/media/mojo/services/mojo_renderer_service.cc
index 9c6f2adf0d11eb581920b6ee7244d8dadd8f09fa..5d75037717ddbf1c1c740f2bd094fb6db27daa56 100644
--- a/media/mojo/services/mojo_renderer_service.cc
+++ b/media/mojo/services/mojo_renderer_service.cc
@@ -36,11 +36,10 @@ MojoRendererService::MojoRendererService(
MojoRendererService::~MojoRendererService() {
}
-void MojoRendererService::Initialize(
- mojom::RendererClientPtr client,
- mojom::DemuxerStreamPtr audio,
- mojom::DemuxerStreamPtr video,
- const mojo::Callback<void(bool)>& callback) {
+void MojoRendererService::Initialize(mojom::RendererClientPtr client,
+ mojom::DemuxerStreamPtr audio,
+ mojom::DemuxerStreamPtr video,
+ const InitializeCallback& callback) {
DVLOG(1) << __FUNCTION__;
DCHECK_EQ(state_, STATE_UNINITIALIZED);
client_ = std::move(client);
@@ -50,7 +49,7 @@ void MojoRendererService::Initialize(
base::Bind(&MojoRendererService::OnStreamReady, weak_this_, callback)));
}
-void MojoRendererService::Flush(const mojo::Closure& callback) {
+void MojoRendererService::Flush(const FlushCallback& callback) {
DVLOG(2) << __FUNCTION__;
DCHECK_EQ(state_, STATE_PLAYING);
@@ -78,7 +77,7 @@ void MojoRendererService::SetVolume(float volume) {
}
void MojoRendererService::SetCdm(int32_t cdm_id,
- const mojo::Callback<void(bool)>& callback) {
+ const SetCdmCallback& callback) {
if (!mojo_cdm_service_context_) {
DVLOG(1) << "CDM service context not available.";
callback.Run(false);
@@ -139,7 +138,7 @@ void MojoRendererService::OnVideoOpacityChange(bool opaque) {
}
void MojoRendererService::OnStreamReady(
- const mojo::Callback<void(bool)>& callback) {
+ const base::Callback<void(bool)>& callback) {
DCHECK_EQ(state_, STATE_INITIALIZING);
renderer_->Initialize(
@@ -149,7 +148,7 @@ void MojoRendererService::OnStreamReady(
}
void MojoRendererService::OnRendererInitializeDone(
- const mojo::Callback<void(bool)>& callback,
+ const base::Callback<void(bool)>& callback,
PipelineStatus status) {
DVLOG(1) << __FUNCTION__;
DCHECK_EQ(state_, STATE_INITIALIZING);
@@ -188,7 +187,7 @@ void MojoRendererService::SchedulePeriodicMediaTimeUpdates() {
base::Bind(&MojoRendererService::UpdateMediaTime, weak_this_, false));
}
-void MojoRendererService::OnFlushCompleted(const mojo::Closure& callback) {
+void MojoRendererService::OnFlushCompleted(const FlushCallback& callback) {
DVLOG(1) << __FUNCTION__;
DCHECK_EQ(state_, STATE_FLUSHING);
state_ = STATE_PLAYING;
@@ -197,7 +196,7 @@ void MojoRendererService::OnFlushCompleted(const mojo::Closure& callback) {
void MojoRendererService::OnCdmAttached(
scoped_refptr<MediaKeys> cdm,
- const mojo::Callback<void(bool)>& callback,
+ const base::Callback<void(bool)>& callback,
bool success) {
DVLOG(1) << __FUNCTION__ << "(" << success << ")";
« no previous file with comments | « media/mojo/services/mojo_renderer_service.h ('k') | mojo/mojo_public.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698