mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl - Issue 2080513002: Deletes mojo::Callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

Issue 2080513002: Deletes mojo::Callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/sync_method_unittest.cc ('k') | mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

index 350728060fdc29507e982c6691a63bc54e8a07e3..c996adc3f2bb618e541a0478c942a2ce18ec6430 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl

@@ -17,7 +17,7 @@ mojo::String {{prefix}}{{param.name}}

{%- endmacro %}

{%- macro declare_callback(method, for_blink) -%}

-mojo::Callback<void(

+base::Callback<void(

{%- for param in method.response_parameters -%}

{#- TODO(yzshen): For historical reasons, we use mojo::String here (instead of

const mojo::String&) inconsistently. Preserve the behavior temporarily. #}