Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2080363002: Rename Geometry.h to PaintSize.h (Closed)

Created:
4 years, 6 months ago by Gleb Lanbin
Modified:
4 years, 6 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Geometry.h to PaintSize.h to follow the CSS Paint API spec https://drafts.css-houdini.org/css-paint-api/#paintsize BUG=578252 Committed: https://crrev.com/5e62a147800dac8b541139623c7eab9b5bda4602 Cr-Commit-Position: refs/heads/master@{#400883}

Patch Set 1 #

Patch Set 2 : change global-interface-listing-paint-worklet-expected.txt #

Patch Set 3 : resolve a merge conflict #

Patch Set 4 : update modules.gypi #

Patch Set 5 : reorder global-interface-listing-paint-worklet-expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -64 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/modules/csspaint/Geometry.h View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/Source/modules/csspaint/Geometry.idl View 1 chunk +0 lines, -13 lines 0 comments Download
A + third_party/WebKit/Source/modules/csspaint/PaintSize.h View 1 chunk +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/modules/csspaint/PaintSize.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (17 generated)
Gleb Lanbin
4 years, 6 months ago (2016-06-20 17:45:48 UTC) #2
ikilpatrick
On 2016/06/20 17:45:48, glebl wrote: lgtm Maybe also mention that this is to follow the ...
4 years, 6 months ago (2016-06-20 21:03:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080363002/20001
4 years, 6 months ago (2016-06-20 21:35:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/23580) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-20 21:38:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080363002/40001
4 years, 6 months ago (2016-06-20 22:34:11 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/130053)
4 years, 6 months ago (2016-06-20 22:38:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080363002/60001
4 years, 6 months ago (2016-06-20 22:45:56 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/249288)
4 years, 6 months ago (2016-06-21 00:03:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080363002/80001
4 years, 6 months ago (2016-06-21 01:44:50 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-21 03:40:20 UTC) #26
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 03:42:22 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5e62a147800dac8b541139623c7eab9b5bda4602
Cr-Commit-Position: refs/heads/master@{#400883}

Powered by Google App Engine
This is Rietveld 408576698