src/objects-body-descriptors-inl.h - Issue 2080243003: Use instance type in Object.prototype.toString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-body-descriptors-inl.h

Issue 2080243003: Use instance type in Object.prototype.toString(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add TODO comment about checking IsArray() before reading toStringTag. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-body-descriptors-inl.h

diff --git a/src/objects-body-descriptors-inl.h b/src/objects-body-descriptors-inl.h

index ee2e01e1b2f0832e739159c57da0ce2a3b3d67bd..cfa945dd6ff72b5d88355de2337b74bbf8d62122 100644

--- a/src/objects-body-descriptors-inl.h

+++ b/src/objects-body-descriptors-inl.h

@@ -456,6 +456,8 @@ ReturnType BodyDescriptorApply(InstanceType type, T1 p1, T2 p2, T3 p3) {

case TRANSITION_ARRAY_TYPE:

return Op::template apply<TransitionArray::BodyDescriptor>(p1, p2, p3);

case JS_OBJECT_TYPE:

+ case JS_ERROR_TYPE:

+ case JS_ARGUMENTS_TYPE:

case JS_PROMISE_TYPE:

case JS_CONTEXT_EXTENSION_OBJECT_TYPE:

case JS_GENERATOR_OBJECT_TYPE:

« no previous file with comments | « src/objects.cc ('k') | src/objects-debug.cc » ('j') | no next file with comments »