Change Numeric sourceInfos into sample diagnostics

Change Numeric sourceInfos into sample diagnostics

Currently, when metrics add samples to Numerics, they can optionally pass an
arbitrary POD javascript object to help users find the sample's source
in a trace. This concept maps directly to the new strongly-typed RelatedEventSet
diagnostic, or diagnostics more generally, which also provide a system to display
the data through tr.v.ui.createDiagnosticSpan().

This CL allows a single un-named Diagnostic object to be associated with each
sample. It may become necessary in the future to allow entire DiagnosticMaps to be
associated with each sample, but we haven't seen a need for that yet.

A future CL will somehow need to associate sample diagnostics with IterationInfos
so that users can actually click through related events.

BUG=catapult:#2180

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/67bdb1c3d8755c1197598eb8f0a5032992979da5

[benjhayden, 2016-06-21 19:49:25]

Description was changed from

==========
Change Numeric sourceInfos into sample diagnostics

BUG=catapult:#2180
==========

to

==========
Change Numeric sourceInfos into sample diagnostics

Currently, when metrics add samples to Numerics, they can optionally pass an
arbitrary POD javascript object to help users find the sample's source
in a trace. This concept maps directly to the new strongly-typed RelatedEventSet
diagnostic, or diagnostics more generally, which also provide a system to
display
the data through tr.v.ui.createDiagnosticSpan().

This CL allows a single un-named Diagnostic object to be associated with each
sample. It may become necessary in the future to allow entire DiagnosticMaps to
be
associated with each sample, but we haven't seen a need for that yet.

A future CL will somehow need to associate sample diagnostics with
IterationInfos
so that users can actually click through related events.

BUG=catapult:#2180
==========

[benjhayden, 2016-06-21 19:49:30]

Patchset #1 (id:1) has been deleted

[benjhayden, 2016-06-21 20:04:16]

Patchset #1 (id:20001) has been deleted

[benjhayden, 2016-06-21 20:05:55]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org, nednguyen@google.com

[benjhayden, 2016-06-21 20:05:56]

PTAL :-)

[eakuefner, 2016-06-24 16:02:40]

lgtm

[benjhayden, 2016-06-27 19:34:32]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-06-27 19:34:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2080183004/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-27 19:34:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 19:57:17]

Description was changed from

==========
Change Numeric sourceInfos into sample diagnostics

Currently, when metrics add samples to Numerics, they can optionally pass an
arbitrary POD javascript object to help users find the sample's source
in a trace. This concept maps directly to the new strongly-typed RelatedEventSet
diagnostic, or diagnostics more generally, which also provide a system to
display
the data through tr.v.ui.createDiagnosticSpan().

This CL allows a single un-named Diagnostic object to be associated with each
sample. It may become necessary in the future to allow entire DiagnosticMaps to
be
associated with each sample, but we haven't seen a need for that yet.

A future CL will somehow need to associate sample diagnostics with
IterationInfos
so that users can actually click through related events.

BUG=catapult:#2180
==========

to

==========
Change Numeric sourceInfos into sample diagnostics

Currently, when metrics add samples to Numerics, they can optionally pass an
arbitrary POD javascript object to help users find the sample's source
in a trace. This concept maps directly to the new strongly-typed RelatedEventSet
diagnostic, or diagnostics more generally, which also provide a system to
display
the data through tr.v.ui.createDiagnosticSpan().

This CL allows a single un-named Diagnostic object to be associated with each
sample. It may become necessary in the future to allow entire DiagnosticMaps to
be
associated with each sample, but we haven't seen a need for that yet.

A future CL will somehow need to associate sample diagnostics with
IterationInfos
so that users can actually click through related events.

BUG=catapult:#2180

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-06-27 19:57:19]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[nednguyen, 2016-06-28 15:27:51]

A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.chromium.org/2101233003/ by nednguyen@google.com.

The reason for reverting is: Cause TBMv2 benchmarks failure everywhere.

BUG=623963.

[benjhayden, 2016-06-29 01:10:11]

Patchset #3 (id:80001) has been deleted