Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: tracing/tracing/metrics/system_health/first_paint_metric.html

Issue 2080183004: Change Numeric sourceInfos into sample diagnostics (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tracing/tracing/metrics/system_health/long_tasks_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/system_health/first_paint_metric.html
diff --git a/tracing/tracing/metrics/system_health/first_paint_metric.html b/tracing/tracing/metrics/system_health/first_paint_metric.html
index f2edb908f076cba6d567a5188e286dcdbde51199..31eed384bbbe6a2f6bc4ead3098a3402244851a1 100644
--- a/tracing/tracing/metrics/system_health/first_paint_metric.html
+++ b/tracing/tracing/metrics/system_health/first_paint_metric.html
@@ -284,7 +284,7 @@ tr.exportTo('tr.metrics.sh', function() {
return;
var timeToEvent = ev.start - navigationStartEvent.start;
- histogram.add(timeToEvent, {url: url});
+ histogram.add(timeToEvent, new tr.v.d.Generic({url: url}));
}, this);
values.addValue(new tr.v.NumericValue(
metric.valueName, histogram,
@@ -362,7 +362,8 @@ tr.exportTo('tr.metrics.sh', function() {
return;
}
var timeToFirstMeaningfulPaint = paintEvent.start - navigationStart.start;
- firstMeaningfulPaintHistogram.add(timeToFirstMeaningfulPaint, {url: url});
+ firstMeaningfulPaintHistogram.add(timeToFirstMeaningfulPaint,
+ new tr.v.d.Generic({url: url}));
}
var layoutsForFrameId = findAllLayoutEvents(rendererHelper);
« no previous file with comments | « no previous file | tracing/tracing/metrics/system_health/long_tasks_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698