Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: tracing/tracing/metrics/system_health/responsiveness_metric.html

Issue 2080183004: Change Numeric sourceInfos into sample diagnostics (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/system_health/long_tasks_metric.html ('k') | tracing/tracing/value/numeric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/system_health/responsiveness_metric.html
diff --git a/tracing/tracing/metrics/system_health/responsiveness_metric.html b/tracing/tracing/metrics/system_health/responsiveness_metric.html
index 5098c535277ddf12329cd935491e86ab4f80a017..99b61e6e17e00edbb91cf5e923a28289e9831364 100644
--- a/tracing/tracing/metrics/system_health/responsiveness_metric.html
+++ b/tracing/tracing/metrics/system_health/responsiveness_metric.html
@@ -89,7 +89,7 @@ tr.exportTo('tr.metrics.sh', function() {
ue.start, ue.end))
return;
- var sourceInfo = {userExpectationId: ue.stableId};
+ var sampleDiagnostic = new tr.v.d.RelatedEventSet([ue]);
// Responsiveness is not defined for Idle.
if (ue instanceof tr.model.um.IdleExpectation) {
@@ -97,27 +97,27 @@ tr.exportTo('tr.metrics.sh', function() {
} else if (ue instanceof tr.model.um.LoadExpectation) {
// This is already covered by firstPaintMetric.
} else if (ue instanceof tr.model.um.ResponseExpectation) {
- responseNumeric.add(ue.duration, sourceInfo);
+ responseNumeric.add(ue.duration, sampleDiagnostic);
} else if (ue instanceof tr.model.um.AnimationExpectation) {
var throughput = computeAnimationThroughput(ue);
if (throughput === undefined)
throw new Error('Missing throughput for ' +
ue.stableId);
- throughputNumeric.add(throughput, sourceInfo);
+ throughputNumeric.add(throughput, sampleDiagnostic);
var frameTimeDiscrepancy = computeAnimationframeTimeDiscrepancy(ue);
if (frameTimeDiscrepancy === undefined)
throw new Error('Missing frameTimeDiscrepancy for ' +
ue.stableId);
- frameTimeDiscrepancyNumeric.add(frameTimeDiscrepancy, sourceInfo);
+ frameTimeDiscrepancyNumeric.add(frameTimeDiscrepancy, sampleDiagnostic);
ue.associatedEvents.forEach(function(event) {
if (!(event instanceof tr.e.cc.InputLatencyAsyncSlice))
return;
- latencyNumeric.add(event.duration, sourceInfo);
+ latencyNumeric.add(event.duration, sampleDiagnostic);
});
} else {
throw new Error('Unrecognized stage for ' + ue.stableId);
« no previous file with comments | « tracing/tracing/metrics/system_health/long_tasks_metric.html ('k') | tracing/tracing/value/numeric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698