Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 208013002: Support invalidation sets for :host pseudo. (Closed)

Created:
6 years, 9 months ago by rune
Modified:
6 years, 9 months ago
Reviewers:
chrishtr, esprehn, ojan
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Support invalidation sets for :host pseudo. Traverse the selectorList() for :host pseudo, extract features, and create class invalidation sets like we do for features and classes on the top level. Supporting invalidation sets for :host is a prerequisite for optimizing style recalc for the "active" attribute in issue 339729. The next step is to support invalidation sets for attributes. R=esprehn@chromium.org, chrishtr@chromium.org BUG=335247, 339729

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -7 lines) Patch
A LayoutTests/fast/css/invalidation/targeted-class-host-pseudo.html View 1 chunk +49 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/targeted-class-host-pseudo-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 4 chunks +37 lines, -7 lines 6 comments Download

Messages

Total messages: 5 (0 generated)
rune
6 years, 9 months ago (2014-03-21 11:08:28 UTC) #1
chrishtr
lgtm
6 years, 9 months ago (2014-03-21 21:40:23 UTC) #2
ojan
lgtm A bunch of cosmetic nits. https://codereview.chromium.org/208013002/diff/1/Source/core/css/RuleFeature.cpp File Source/core/css/RuleFeature.cpp (right): https://codereview.chromium.org/208013002/diff/1/Source/core/css/RuleFeature.cpp#newcode124 Source/core/css/RuleFeature.cpp:124: if (list) { ...
6 years, 9 months ago (2014-03-22 00:32:23 UTC) #3
esprehn
not lgtm, this patch is not correct as is. :host() can definitely have more than ...
6 years, 9 months ago (2014-03-22 01:25:34 UTC) #4
rune
6 years, 9 months ago (2014-03-24 11:27:34 UTC) #5
Message was sent while issue was closed.
Re-submitted as:

https://codereview.chromium.org/209333005/

Closing.

Powered by Google App Engine
This is Rietveld 408576698