Support invalidation sets for :host pseudo.

Source/core/css/RuleFeature.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
@@ skipping 36 matching lines @@
 
 namespace WebCore {
 
 static bool isSkippableComponentForInvalidation(const CSSSelector& selector)
 {
     if (selector.m_match == CSSSelector::Tag
         || selector.m_match == CSSSelector::Id
         || selector.isAttributeSelector())
         return true;
     if (selector.m_match == CSSSelector::PseudoElement) {
-        switch (selector.m_pseudoType) {
+        switch (selector.pseudoType()) {
         case CSSSelector::PseudoBefore:
         case CSSSelector::PseudoAfter:
         case CSSSelector::PseudoBackdrop:
             return true;
         default:
             return false;
         }
     }
     if (selector.m_match != CSSSelector::PseudoClass)
         return false;
@@ skipping 44 matching lines @@
 RuleFeatureSet::InvalidationSetMode RuleFeatureSet::supportsClassDescendantInvalidation(const CSSSelector& selector)
 {
     bool foundDescendantRelation = false;
     bool foundIdent = false;
     for (const CSSSelector* component = &selector; component; component = component->tagHistory()) {
 
         // FIXME: next up: Tag and Id.
         if (component->m_match == CSSSelector::Class) {
             if (!foundDescendantRelation)
                 foundIdent = true;
+        } else if (component->pseudoType() == CSSSelector::PseudoHost) {
+            const CSSSelectorList* list = component->selectorList();
+            if (list) {

[ojan, 2014/03/22 00:32:23]

Nit: typically we write this as follows: 
if (const CSSSelectorList* list = component->selectorList()) {

In addition to being one line, it has the advantage of scoping the variable to
the contents of the if-statement.

+                ASSERT(list->hasOneSelector());

[esprehn, 2014/03/22 01:25:34]

Why does this have to have one selector? You can write host(a, b)

+                InvalidationSetMode hostMode = supportsClassDescendantInvalidation(*list->first());
+                if (hostMode == UseSubtreeStyleChange)
+                    return foundDescendantRelation ? UseLocalStyleChange : UseSubtreeStyleChange;
+                if (hostMode == AddFeatures)
+                    foundIdent = true;
+            }
         } else if (!isSkippableComponentForInvalidation(*component)) {
             return foundDescendantRelation ? UseLocalStyleChange : UseSubtreeStyleChange;
         }
         switch (component->relation()) {
         case CSSSelector::Descendant:
         case CSSSelector::Child:
         case CSSSelector::Shadow:
         case CSSSelector::ShadowDeep:
             foundDescendantRelation = true;
             // Fall through!
@@ skipping 24 matching lines @@
 RuleFeatureSet::InvalidationSetMode RuleFeatureSet::updateClassInvalidationSets(const CSSSelector& selector)
 {
     InvalidationSetMode mode = supportsClassDescendantInvalidation(selector);
     if (mode != AddFeatures)
         return mode;
 
     Vector<AtomicString> classes;
     AtomicString id;
     AtomicString tagName;
 
+    const CSSSelector* current = extractInvalidationSetFeatures(selector, classes, id, tagName);
+    if (!current || !(current = current->tagHistory()))

[ojan, 2014/03/22 00:32:23]

Nit: In contrast to the above case, I find setting current inside the
if-statement confusing. It looks like a typo. I can see that it's not by
inspecting the code closely.

The difference with the above case IMO is the type. The type means it would be a
compiler error if you change the = to an ==.

[esprehn, 2014/03/22 01:25:34]

Don't do assignments inside || or &&

+        return AddFeatures;
+
+    addFeaturesToInvalidationSets(*current, classes, id, tagName);
+    return AddFeatures;
+}
+
+const CSSSelector* RuleFeatureSet::extractInvalidationSetFeatures(const CSSSelector& selector, Vector<AtomicString>& classes, AtomicString& id, AtomicString& tagName)
+{
     const CSSSelector* lastSelector = &selector;
     for (; lastSelector; lastSelector = lastSelector->tagHistory()) {
         extractClassIdOrTag(*lastSelector, classes, id, tagName);
-        if (lastSelector->m_match == CSSSelector::Class)
+        if (lastSelector->m_match == CSSSelector::Class) {
             ensureClassInvalidationSet(lastSelector->value());
+        } else if (lastSelector->pseudoType() == CSSSelector::PseudoHost) {
+            const CSSSelectorList* list = lastSelector->selectorList();
+            if (list)

[ojan, 2014/03/22 00:32:23]

Ditto first comment.

+                extractInvalidationSetFeatures(*list->first(), classes, id, tagName);
+        }
+
         if (lastSelector->relation() != CSSSelector::SubSelector)
             break;
     }
+    return lastSelector;
+}
 
-    if (!lastSelector)
-        return AddFeatures;
-
-    for (const CSSSelector* current = lastSelector->tagHistory(); current; current = current->tagHistory()) {
+void RuleFeatureSet::addFeaturesToInvalidationSets(const CSSSelector& selector, const Vector<AtomicString>& classes, AtomicString id, AtomicString tagName)
+{
+    const CSSSelector* current = &selector;
+    for (; current; current = current->tagHistory()) {
         if (current->m_match == CSSSelector::Class) {
             DescendantInvalidationSet& invalidationSet = ensureClassInvalidationSet(current->value());
             if (!id.isEmpty())
                 invalidationSet.addId(id);
             if (!tagName.isEmpty())
                 invalidationSet.addTagName(tagName);
             for (Vector<AtomicString>::const_iterator it = classes.begin(); it != classes.end(); ++it) {
                 invalidationSet.addClass(*it);
             }
+        } else if (current->pseudoType() == CSSSelector::PseudoHost) {
+            if  (current->selectorList())

[ojan, 2014/03/22 00:32:23]

Nit: extra space after the if.

+                addFeaturesToInvalidationSets(*current->selectorList()->first(), classes, id, tagName);
         }
     }
-    return AddFeatures;
 }
 
 void RuleFeatureSet::addAttributeInASelector(const AtomicString& attributeName)
 {
     m_metadata.attrsInRules.add(attributeName);
 }
 
 void RuleFeatureSet::collectFeaturesFromRuleData(const RuleData& ruleData)
 {
     FeatureMetadata metadata;
@@ skipping 174 matching lines @@
     if (node->isElementNode())
         m_pendingInvalidationMap.remove(toElement(node));
 }
 
 RuleFeatureSet::PendingInvalidationMap& RuleFeatureSet::pendingInvalidationMap()
 {
     return m_pendingInvalidationMap;
 }
 
 } // namespace WebCore