Chromium Code Reviews| Index: chrome_elf/chrome_elf.gyp |
| diff --git a/chrome_elf/chrome_elf.gyp b/chrome_elf/chrome_elf.gyp |
| index 22e77b81eeae13a8e9752068a366f69d01ff0277..2afec8102168fc4cba637bb5483c1a2736304d4f 100644 |
| --- a/chrome_elf/chrome_elf.gyp |
| +++ b/chrome_elf/chrome_elf.gyp |
| @@ -75,6 +75,7 @@ |
| 'blacklist/test/blacklist_test.cc', |
| 'chrome_elf_util_unittest.cc', |
| 'elf_imports_unittest.cc', |
| + 'run_all_unittests.cc', |
| ], |
| 'include_dirs': [ |
| '..', |
| @@ -93,6 +94,18 @@ |
| 'blacklist_test_dll_3', |
| 'blacklist_test_main_dll', |
| ], |
| + 'msvs_settings': { |
| + 'VCLinkerTool': { |
| + # Set /SUBSYSTEM:WINDOWS. |
| + 'SubSystem': '2', |
|
scottmg
2016/06/18 17:36:57
Why /subsystem:windows? Aren't we running main()?
ananta
2016/06/20 19:08:03
Removed.
|
| + 'AdditionalDependencies!': [ |
| + 'user32.lib', |
| + ], |
| + 'IgnoreDefaultLibraryNames': [ |
| + 'user32.lib', |
| + ], |
| + }, |
|
scottmg
2016/06/18 17:36:57
Do we not need all the delayloads that are in the
ananta
2016/06/20 19:08:03
No. The gn build pulls in a dependency on chrome a
|
| + }, |
| }, |
| { |
| # A dummy target to ensure that chrome_elf.dll and chrome.exe gets built |