Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: chrome_elf/chrome_elf.gyp

Issue 2078913005: Add a chrome_elf_unittest ChromeElfLoadSanityTest which validates that loading chrome_elf does not … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_elf/chrome_elf.gyp
diff --git a/chrome_elf/chrome_elf.gyp b/chrome_elf/chrome_elf.gyp
index 22e77b81eeae13a8e9752068a366f69d01ff0277..2afec8102168fc4cba637bb5483c1a2736304d4f 100644
--- a/chrome_elf/chrome_elf.gyp
+++ b/chrome_elf/chrome_elf.gyp
@@ -75,6 +75,7 @@
'blacklist/test/blacklist_test.cc',
'chrome_elf_util_unittest.cc',
'elf_imports_unittest.cc',
+ 'run_all_unittests.cc',
],
'include_dirs': [
'..',
@@ -93,6 +94,18 @@
'blacklist_test_dll_3',
'blacklist_test_main_dll',
],
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ # Set /SUBSYSTEM:WINDOWS.
+ 'SubSystem': '2',
scottmg 2016/06/18 17:36:57 Why /subsystem:windows? Aren't we running main()?
ananta 2016/06/20 19:08:03 Removed.
+ 'AdditionalDependencies!': [
+ 'user32.lib',
+ ],
+ 'IgnoreDefaultLibraryNames': [
+ 'user32.lib',
+ ],
+ },
scottmg 2016/06/18 17:36:57 Do we not need all the delayloads that are in the
ananta 2016/06/20 19:08:03 No. The gn build pulls in a dependency on chrome a
+ },
},
{
# A dummy target to ensure that chrome_elf.dll and chrome.exe gets built

Powered by Google App Engine
This is Rietveld 408576698