Add a chrome_elf_unittest ChromeElfLoadSanityTest which validates that loading chrome_elf does not …

chrome_elf/chrome_elf.gyp

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'variables': {
     'chromium_code': 1,
   },
   'includes': [
     '../build/util/version.gypi',
     '../build/win_precompile.gypi',
@@ skipping 57 matching lines @@
       },
     },
     {
       'target_name': 'chrome_elf_unittests_exe',
       'product_name': 'chrome_elf_unittests',
       'type': 'executable',
       'sources': [
         'blacklist/test/blacklist_test.cc',
         'chrome_elf_util_unittest.cc',
         'elf_imports_unittest.cc',
+        'run_all_unittests.cc',
       ],
       'include_dirs': [
         '..',
         '<(SHARED_INTERMEDIATE_DIR)',
       ],
       'dependencies': [
         '../base/base.gyp:base',
         '../base/base.gyp:run_all_unittests',
         '../base/base.gyp:test_support_base',
         '../chrome/chrome.gyp:install_static_util',
         '../sandbox/sandbox.gyp:sandbox',
         '../testing/gtest.gyp:gtest',
         'blacklist',
         'blacklist_test_dll_1',
         'blacklist_test_dll_2',
         'blacklist_test_dll_3',
         'blacklist_test_main_dll',
       ],
+      'msvs_settings': {
+        'VCLinkerTool': {
+          # Set /SUBSYSTEM:WINDOWS.
+          'SubSystem': '2',

[scottmg, 2016/06/18 17:36:57]

Why /subsystem:windows? Aren't we running main()?

[ananta, 2016/06/20 19:08:03]

Removed.

+          'AdditionalDependencies!': [
+            'user32.lib',
+          ],
+          'IgnoreDefaultLibraryNames': [
+            'user32.lib',
+          ],
+        },

[scottmg, 2016/06/18 17:36:57]

Do we not need all the delayloads that are in the gn?

[ananta, 2016/06/20 19:08:03]

No. The gn build pulls in a dependency on chrome and hence.

+      },
     },
     {
       # A dummy target to ensure that chrome_elf.dll and chrome.exe gets built
       # when building chrome_elf_unittests.exe without introducing an
       # explicit runtime dependency.
       'target_name': 'chrome_elf_unittests',
       'type': 'none',
       'dependencies': [
         '../chrome/chrome.gyp:chrome',
         '../chrome/chrome.gyp:install_static_util',
@@ skipping 54 matching lines @@
           'dependencies': [
             'chrome_elf_unittests',
           ],
           'includes': [ '../build/isolate.gypi' ],
           'sources': [ 'chrome_elf_unittests.isolate' ],
         },
       ],
     }],
   ],
 }