Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2855)

Unified Diff: base/command_line.h

Issue 2078913005: Add a chrome_elf_unittest ChromeElfLoadSanityTest which validates that loading chrome_elf does not … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/command_line.cc » ('j') | chrome_elf/chrome_elf.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/command_line.h
diff --git a/base/command_line.h b/base/command_line.h
index 3de8873e26aa608352415065ac4885ae238044be..3196bb41a74504fc346e01c7657068a44f1f7294 100644
--- a/base/command_line.h
+++ b/base/command_line.h
@@ -69,6 +69,15 @@ class BASE_EXPORT CommandLine {
// object and the behavior will be the same as Posix systems (only hyphens
// begin switches, everything else will be an arg).
static void set_slash_is_not_a_switch();
+
+ // Normally when the CommandLine singleton is initialized it gets the command
+ // line via the GetCommandLineW API and then uses the shell32 API
+ // CommandLineToArgVW to parse the command line and convert it back to argc
scottmg 2016/06/18 17:36:57 CommandLineToArgvW
ananta 2016/06/20 19:08:03 Done.
+ // and argv. We may want to honor the command line arguments passed in via
+ // main for console tests. The |honor_args_for_testing| parameter controls
+ // that behavior.
+ static void set_honor_command_line_args_for_testing(
scottmg 2016/06/18 17:36:57 Maybe "set_honor_argv_for_testing" would be more a
ananta 2016/06/20 19:08:03 Done.
+ bool honor_args_for_testing);
#endif
// Initialize the current process CommandLine singleton. On Windows, ignores
« no previous file with comments | « no previous file | base/command_line.cc » ('j') | chrome_elf/chrome_elf.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698