Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1664)

Issue 2078663002: [Sync] Deprecate old histograms (Closed)

Created:
4 years, 6 months ago by Nicolas Zea
Modified:
4 years, 6 months ago
Reviewers:
rkaplow, pavely
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Deprecate old histograms This histograms are no longer being used, and can be deprecated. BUG=none Committed: https://crrev.com/6ad03d918c74a29f277cf5e6eaba60e460fb95ed Cr-Commit-Position: refs/heads/master@{#400635}

Patch Set 1 #

Patch Set 2 : More cleanup #

Patch Set 3 : Missing histogram #

Patch Set 4 : Leave old enum usage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -117 lines) Patch
M components/browser_sync/browser/profile_sync_service.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service.cc View 1 2 3 3 chunks +0 lines, -36 lines 0 comments Download
M components/sync_driver/device_info_sync_service.cc View 1 3 chunks +0 lines, -42 lines 0 comments Download
M components/sync_driver/glue/sync_backend_host_core.cc View 1 3 chunks +0 lines, -26 lines 0 comments Download
M components/sync_sessions/favicon_cache.cc View 1 3 chunks +0 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 32 chunks +108 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Nicolas Zea
+Pavel, PTAL
4 years, 6 months ago (2016-06-16 21:47:17 UTC) #2
pavely
lgtm
4 years, 6 months ago (2016-06-16 21:50:47 UTC) #3
Nicolas Zea
+rkaplow for histo's
4 years, 6 months ago (2016-06-16 22:00:18 UTC) #5
rkaplow
lgtm
4 years, 6 months ago (2016-06-16 22:09:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078663002/40001
4 years, 6 months ago (2016-06-16 22:13:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/229746)
4 years, 6 months ago (2016-06-16 22:21:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078663002/60001
4 years, 6 months ago (2016-06-20 07:24:09 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-20 08:20:52 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 08:22:57 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6ad03d918c74a29f277cf5e6eaba60e460fb95ed
Cr-Commit-Position: refs/heads/master@{#400635}

Powered by Google App Engine
This is Rietveld 408576698