Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: components/browser_sync/browser/profile_sync_service.cc

Issue 2078663002: [Sync] Deprecate old histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Leave old enum usage Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/browser/profile_sync_service.cc
diff --git a/components/browser_sync/browser/profile_sync_service.cc b/components/browser_sync/browser/profile_sync_service.cc
index 95a951dfedc552f8a56d2297eb16ad4dba80a54d..1b2911e47c5e158e9faa91cd299b4145c9d69d90 100644
--- a/components/browser_sync/browser/profile_sync_service.cc
+++ b/components/browser_sync/browser/profile_sync_service.cc
@@ -360,8 +360,6 @@ void ProfileSyncService::Initialize() {
StopImpl(CLEAR_DATA);
}
- TrySyncDatatypePrefRecovery();
-
#if defined(OS_CHROMEOS)
std::string bootstrap_token = sync_prefs_.GetEncryptionBootstrapToken();
if (bootstrap_token.empty()) {
@@ -383,37 +381,6 @@ void ProfileSyncService::Initialize() {
startup_controller_->TryStart();
}
-void ProfileSyncService::TrySyncDatatypePrefRecovery() {
- DCHECK(!IsBackendInitialized());
- if (!IsFirstSetupComplete())
- return;
-
- // There was a bug where OnUserChoseDatatypes was not properly called on
- // configuration (see crbug.com/154940). We detect this by checking whether
- // kSyncKeepEverythingSynced has a default value. If so, and sync setup has
- // completed, it means sync was not properly configured, so we manually
- // set kSyncKeepEverythingSynced.
- PrefService* const pref_service = sync_client_->GetPrefService();
- if (!pref_service)
- return;
- if (GetPreferredDataTypes().Size() > 1)
- return;
-
- const PrefService::Preference* keep_everything_synced =
- pref_service->FindPreference(
- sync_driver::prefs::kSyncKeepEverythingSynced);
- // This will be false if the preference was properly set or if it's controlled
- // by policy.
- if (!keep_everything_synced->IsDefaultValue())
- return;
-
- // kSyncKeepEverythingSynced was not properly set. Set it and the preferred
- // types now, before we configure.
- UMA_HISTOGRAM_COUNTS("Sync.DatatypePrefRecovery", 1);
- sync_prefs_.SetKeepEverythingSynced(true);
- syncer::ModelTypeSet registered_types = GetRegisteredDataTypes();
-}
-
void ProfileSyncService::StartSyncingWithServer() {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -651,9 +618,6 @@ void ProfileSyncService::OnGetTokenSuccess(
if (sync_prefs_.SyncHasAuthError()) {
sync_prefs_.SetSyncAuthError(false);
- UMA_HISTOGRAM_ENUMERATION("Sync.SyncAuthError",
- AUTH_ERROR_FIXED,
- AUTH_ERROR_LIMIT);
}
if (HasSyncingBackend())
« no previous file with comments | « components/browser_sync/browser/profile_sync_service.h ('k') | components/sync_driver/device_info_sync_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698