Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: components/sync_sessions/favicon_cache.cc

Issue 2078663002: [Sync] Deprecate old histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Leave old enum usage Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync_driver/glue/sync_backend_host_core.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync_sessions/favicon_cache.cc
diff --git a/components/sync_sessions/favicon_cache.cc b/components/sync_sessions/favicon_cache.cc
index 3edd698b980153777df319ee7302495091a07a09..51e9494d3fb86cf8e339942f81ddd6f017508d46 100644
--- a/components/sync_sessions/favicon_cache.cc
+++ b/components/sync_sessions/favicon_cache.cc
@@ -280,8 +280,6 @@ syncer::SyncMergeResult FaviconCache::MergeDataAndStartSyncing(
// they'll be re-added and the appropriate synced favicons will be evicted.
// TODO(zea): implement a smarter ordering of the which favicons to drop.
int available_favicons = max_sync_favicon_limit_ - initial_sync_data.size();
- UMA_HISTOGRAM_BOOLEAN("Sync.FaviconsAvailableAtMerge",
- available_favicons > 0);
for (std::set<GURL>::const_iterator iter = unsynced_favicon_urls.begin();
iter != unsynced_favicon_urls.end(); ++iter) {
if (available_favicons > 0) {
@@ -298,7 +296,6 @@ syncer::SyncMergeResult FaviconCache::MergeDataAndStartSyncing(
merge_result.set_num_items_deleted(merge_result.num_items_deleted() + 1);
}
}
- UMA_HISTOGRAM_COUNTS_10000("Sync.FaviconCount", synced_favicons_.size());
merge_result.set_num_items_after_association(synced_favicons_.size());
if (type == syncer::FAVICON_IMAGES) {
@@ -621,11 +618,6 @@ void FaviconCache::OnFaviconDataAvailable(
// TODO(zea): support multiple favicon urls per page.
page_favicon_map_[page_url] = favicon_url;
- if (!favicon_info->last_visit_time.is_null()) {
- UMA_HISTOGRAM_COUNTS_10000(
- "Sync.FaviconVisitPeriod",
- (now - favicon_info->last_visit_time).InHours());
- }
favicon_info->received_local_update = true;
UpdateFaviconVisitTime(favicon_url, now);
« no previous file with comments | « components/sync_driver/glue/sync_backend_host_core.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698