Support sRGB dsts in opt code

Support sRGB dsts in opt code

201295.jpg on HP z620 (300x280)

QCMS Xform                    0.418 ms
Skia NEW Xform                0.378 ms

Vs QCMS                       1.11x

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2078623002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/d2809573deb7b99e764f7f71fe34a5b5322df0b2

[msarett, 2016-06-16 20:39:29]

Description was changed from

==========
Support sRGB dsts in opt code

BUG=skia:
==========

to

==========
Support sRGB dsts in opt code

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2078623002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[msarett, 2016-06-17 16:37:31]

Patchset #1 (id:1) has been deleted

[msarett, 2016-06-17 16:46:22]

Patchset #1 (id:20001) has been deleted

[msarett, 2016-06-17 17:10:30]

Description was changed from

==========
Support sRGB dsts in opt code

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2078623002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Support sRGB dsts in opt code

201295.jpg on HP z620 (300x280)

QCMS Xform                    0.495 ms
Skia Old (Inaccurate) Xform   0.235 ms
Skia NEW Xform                0.365 ms

Vs Old Code                   0.64x
Vs QCMS                       1.36x

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2078623002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[msarett, 2016-06-17 17:16:46]

msarett@google.com changed reviewers:
+ brianosman@google.com, mtklein@google.com, reed@google.com

[mtklein, 2016-06-17 17:19:40]

https://codereview.chromium.org/2078623002/diff/40001/src/opts/SkColorXform_o...
File src/opts/SkColorXform_opts.h (right):

https://codereview.chromium.org/2078623002/diff/40001/src/opts/SkColorXform_o...
src/opts/SkColorXform_opts.h:174: return _mm_or_ps(_mm_and_ps(a, mask),
_mm_andnot_ps(b, mask));
and(mask, a) or andnot(mask, b)

[msarett, 2016-06-17 20:05:23]

Description was changed from

==========
Support sRGB dsts in opt code

201295.jpg on HP z620 (300x280)

QCMS Xform                    0.495 ms
Skia Old (Inaccurate) Xform   0.235 ms
Skia NEW Xform                0.365 ms

Vs Old Code                   0.64x
Vs QCMS                       1.36x

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2078623002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Support sRGB dsts in opt code

201295.jpg on HP z620 (300x280)

QCMS Xform                    0.418 ms
Skia NEW Xform                0.378 ms

Vs QCMS                       1.11x

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2078623002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[msarett, 2016-06-17 20:10:11]

This was easy!

Worth noting that my switch to clang has made qcms significantly faster.  So now
we're competing against a new baseline (but at least it's the correct baseline
now).

https://codereview.chromium.org/2078623002/diff/40001/src/opts/SkColorXform_o...
File src/opts/SkColorXform_opts.h (right):

https://codereview.chromium.org/2078623002/diff/40001/src/opts/SkColorXform_o...
src/opts/SkColorXform_opts.h:174: return _mm_or_ps(_mm_and_ps(a, mask),
_mm_andnot_ps(b, mask));
On 2016/06/17 17:19:40, mtklein wrote:
> and(mask, a) or andnot(mask, b)

Let's just use Sk4f haha :).

https://codereview.chromium.org/2078623002/diff/60001/src/opts/SkColorXform_o...
File src/opts/SkColorXform_opts.h (right):

https://codereview.chromium.org/2078623002/diff/60001/src/opts/SkColorXform_o...
src/opts/SkColorXform_opts.h:160: static Sk4f linear_to_srgb(const Sk4f& x) {
Let me know if you see anything worth double-checking here.

The switch to clang/4f has slowed us about 0.010 ms.  It's probably a little
obsessive to try to identify the cause, but if something jumps out at you...

[mtklein, 2016-06-17 20:42:02]

lgtm

https://codereview.chromium.org/2078623002/diff/60001/src/opts/SkColorXform_o...
File src/opts/SkColorXform_opts.h (right):

https://codereview.chromium.org/2078623002/diff/60001/src/opts/SkColorXform_o...
src/opts/SkColorXform_opts.h:171: ((+0.678513029959381f * 255.0f) * sqrt +
do () really matter?

[msarett, 2016-06-17 21:18:25]

https://codereview.chromium.org/2078623002/diff/60001/src/opts/SkColorXform_o...
File src/opts/SkColorXform_opts.h (right):

https://codereview.chromium.org/2078623002/diff/60001/src/opts/SkColorXform_o...
src/opts/SkColorXform_opts.h:171: ((+0.678513029959381f * 255.0f) * sqrt +
On 2016/06/17 20:42:02, mtklein wrote:
> do () really matter?

I removed them.  If they matter, it's so small that it's hard to tell.

[msarett, 2016-06-17 21:18:56]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 21:18:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2078623002/80001

[commit-bot: I haz the power, 2016-06-17 21:39:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 21:39:22]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-06-20 12:48:43]

The CQ bit was checked by msarett@google.com

[msarett, 2016-06-20 12:48:43]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/2078623002/#ps80001
(title: "Drop parens")

[commit-bot: I haz the power, 2016-06-20 12:48:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2078623002/80001

[commit-bot: I haz the power, 2016-06-20 13:07:49]

Description was changed from

==========
Support sRGB dsts in opt code

201295.jpg on HP z620 (300x280)

QCMS Xform                    0.418 ms
Skia NEW Xform                0.378 ms

Vs QCMS                       1.11x

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2078623002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Support sRGB dsts in opt code

201295.jpg on HP z620 (300x280)

QCMS Xform                    0.418 ms
Skia NEW Xform                0.378 ms

Vs QCMS                       1.11x

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2078623002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/d2809573deb7b99e764f7f71fe34a5b5322df0b2
==========

[commit-bot: I haz the power, 2016-06-20 13:07:50]

Committed patchset #3 (id:80001) as
https://skia.googlesource.com/skia/+/d2809573deb7b99e764f7f71fe34a5b5322df0b2