Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2078443002: [builtins] Use BUILTIN frame in DatePrototype_GetField (Closed)

Created:
4 years, 6 months ago by jgruber
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@20160616-builtin-frame
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Use BUILTIN frame in DatePrototype_GetField Construct a BUILTIN frame before throwing an exception from runtime. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/198e09de5a72eb734918bdf3943f37202fdc644d Cr-Commit-Position: refs/heads/master@{#37053}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Do not store argc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -8 lines) Patch
M src/arm/builtins-arm.cc View 1 3 chunks +12 lines, -2 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 3 chunks +12 lines, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 1 2 chunks +11 lines, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 chunks +11 lines, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-4815.js View 1 1 chunk +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2069423002 Patch 20001

Messages

Total messages: 17 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078443002/1
4 years, 6 months ago (2016-06-16 10:43:23 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 11:12:55 UTC) #4
jgruber
4 years, 6 months ago (2016-06-16 11:22:26 UTC) #5
Benedikt Meurer
Same for the other platforms. https://codereview.chromium.org/2078443002/diff/1/src/arm/builtins-arm.cc File src/arm/builtins-arm.cc (right): https://codereview.chromium.org/2078443002/diff/1/src/arm/builtins-arm.cc#newcode1747 src/arm/builtins-arm.cc:1747: __ Move(r4, r0); // ...
4 years, 6 months ago (2016-06-16 11:37:05 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078443002/20001
4 years, 6 months ago (2016-06-16 15:58:47 UTC) #8
jgruber
https://codereview.chromium.org/2078443002/diff/1/src/arm/builtins-arm.cc File src/arm/builtins-arm.cc (right): https://codereview.chromium.org/2078443002/diff/1/src/arm/builtins-arm.cc#newcode1747 src/arm/builtins-arm.cc:1747: __ Move(r4, r0); // Store argc for builtin frame ...
4 years, 6 months ago (2016-06-16 15:59:21 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 16:25:09 UTC) #11
Benedikt Meurer
Nice, thanks. LGTM!
4 years, 6 months ago (2016-06-16 17:49:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078443002/20001
4 years, 6 months ago (2016-06-17 07:41:56 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 07:43:57 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 07:44:50 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/198e09de5a72eb734918bdf3943f37202fdc644d
Cr-Commit-Position: refs/heads/master@{#37053}

Powered by Google App Engine
This is Rietveld 408576698