[builtins] Use BUILTIN frame in DatePrototype_GetField

src/arm/builtins-arm.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if V8_TARGET_ARCH_ARM
 
 #include "src/codegen.h"
 #include "src/debug/debug.h"
 #include "src/deoptimizer.h"
 #include "src/full-codegen/full-codegen.h"
@@ skipping 1716 matching lines @@
     // And "return" to the OSR entry point of the function.
     __ Ret();
   }
 }
 
 
 // static
 void Builtins::Generate_DatePrototype_GetField(MacroAssembler* masm,
                                                int field_index) {
   // ----------- S t a t e -------------
+  //  -- r0    : number of arguments
+  //  -- r1    : function
+  //  -- cp    : context
   //  -- lr    : return address
   //  -- sp[0] : receiver
   // -----------------------------------
 
   // 1. Pop receiver into r0 and check that it's actually a JSDate object.
   Label receiver_not_date;
   {
+    __ Move(r4, r0);  // Store argc for builtin frame construction.

[Benedikt Meurer, 2016/06/16 11:37:05]

You don't need to remember r0 here, because it's always 0 in this builtin. This
builtin is always called with only the receiver on the stack (because we say
adapt arguments in the bootstrapper).

[jgruber, 2016/06/16 15:59:21]

Done.

     __ Pop(r0);
     __ JumpIfSmi(r0, &receiver_not_date);
-    __ CompareObjectType(r0, r1, r2, JS_DATE_TYPE);
+    __ CompareObjectType(r0, r2, r3, JS_DATE_TYPE);
     __ b(ne, &receiver_not_date);
   }
 
   // 2. Load the specified date field, falling back to the runtime as necessary.
   if (field_index == JSDate::kDateValue) {
     __ ldr(r0, FieldMemOperand(r0, JSDate::kValueOffset));
   } else {
     if (field_index < JSDate::kFirstUncachedField) {
       Label stamp_mismatch;
       __ mov(r1, Operand(ExternalReference::date_cache_stamp(masm->isolate())));
       __ ldr(r1, MemOperand(r1));
       __ ldr(ip, FieldMemOperand(r0, JSDate::kCacheStampOffset));
       __ cmp(r1, ip);
       __ b(ne, &stamp_mismatch);
       __ ldr(r0, FieldMemOperand(
                      r0, JSDate::kValueOffset + field_index * kPointerSize));
       __ Ret();
       __ bind(&stamp_mismatch);
     }
     FrameScope scope(masm, StackFrame::INTERNAL);
     __ PrepareCallCFunction(2, r1);
     __ mov(r1, Operand(Smi::FromInt(field_index)));
     __ CallCFunction(
         ExternalReference::get_date_field_function(masm->isolate()), 2);
   }
   __ Ret();
 
   // 3. Raise a TypeError if the receiver is not a date.
   __ bind(&receiver_not_date);
-  __ TailCallRuntime(Runtime::kThrowNotDateError);
+  {
+    FrameScope scope(masm, StackFrame::MANUAL);
+    __ Push(r0, lr, fp);
+    __ Move(fp, sp);
+    __ SmiTag(r4);
+    __ Push(cp, r1, r4);
+    __ CallRuntime(Runtime::kThrowNotDateError);
+  }
 }
 
 // static
 void Builtins::Generate_FunctionPrototypeApply(MacroAssembler* masm) {
   // ----------- S t a t e -------------
   //  -- r0    : argc
   //  -- sp[0] : argArray
   //  -- sp[4] : thisArg
   //  -- sp[8] : receiver
   // -----------------------------------
@@ skipping 1084 matching lines @@
   }
 }
 
 
 #undef __
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_ARM