Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2069423002: [builtins] Introduce a proper BUILTIN frame type. (Closed)

Created:
4 years, 6 months ago by jgruber
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Introduce a proper BUILTIN frame type. This adds a new BUILTIN frame type, which supports variable number of arguments for builtins implemented in hand-written native code (we will extend this mechanism to TurboFan builtins at some point). Convert the Math.max and Math.min builtins to construct a BUILTIN frame if required. This does not yet work for C++ builtins, but that'll be the next step. R=bmeurer@chromium.org, jarin@chromium.org BUG=v8:4815 LOG=n Committed: https://crrev.com/f47b9e981035c887bda5ae66203e458eb37a5a65 Cr-Commit-Position: refs/heads/master@{#37051}

Patch Set 1 #

Patch Set 2 : Fix clobbered reg in mips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -70 lines) Patch
M src/arm/builtins-arm.cc View 4 chunks +19 lines, -13 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 4 chunks +22 lines, -16 lines 0 comments Download
M src/frames.h View 5 chunks +34 lines, -3 lines 0 comments Download
M src/frames.cc View 4 chunks +18 lines, -9 lines 0 comments Download
M src/frames-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 4 chunks +10 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 1 4 chunks +20 lines, -13 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 4 chunks +20 lines, -13 lines 0 comments Download
M src/x64/builtins-x64.cc View 4 chunks +10 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-4815.js View 1 chunk +20 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069423002/1
4 years, 6 months ago (2016-06-16 10:39:43 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 11:08:32 UTC) #4
jgruber
This is based off Benedikt's CL at https://codereview.chromium.org/1902373002/. Fixed a problem with stack drop logic ...
4 years, 6 months ago (2016-06-16 11:21:54 UTC) #5
Benedikt Meurer
LGTM, thanks.
4 years, 6 months ago (2016-06-16 11:38:03 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069423002/20001
4 years, 6 months ago (2016-06-16 14:47:17 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 15:15:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2069423002/20001
4 years, 6 months ago (2016-06-17 07:38:35 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 07:40:19 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 07:41:45 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f47b9e981035c887bda5ae66203e458eb37a5a65
Cr-Commit-Position: refs/heads/master@{#37051}

Powered by Google App Engine
This is Rietveld 408576698